Giter VIP home page Giter VIP logo

Comments (2)

robertdfrench avatar robertdfrench commented on August 23, 2024

In e187ac1 you showed that we can just write Path::new("./target/debug/whatever") and it will still work on Windows. But to answer this question completely, I removed the leading ./ and all the tests still passed:

     #[test]
     fn query_version_info() {
-        let path = Path::new("./target/debug/fake_git");
+        let path = Path::new("target/debug/fake_git");
         let fake_git = Git::with_path(path);
         let version = fake_git.version().unwrap();
         assert!(version.starts_with("fake_git version 1"));

So you are right; we do not need the relative prefix here. I am inclined to say we leave it anyhow, since it's a little more explicit and Windows seems to tolerate it. But if you want to drop it, I'm not opposed.

from git-pr.

calebwherry avatar calebwherry commented on August 23, 2024

I'm fine with leaving it, I think it makes it more clear on the intention of running from the PWD.

from git-pr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.