AuthenticateAsClientAsync doesn't respect ReadTimeout in a certain scenario about fluentftp HOT 4 OPEN

Thanks for this report. Let's take it apart into separate pieces:

I also found this #682 where looks like SslBuffering.Off was a worarkound. This no longer works.

Let's check that SSL Buffering is actually turned off. There should be a message in the log (verbose!) stating that no SSL Buffering is actually being used (because->.NET 8). So your turning this off yourself "is overkill". And since this doesn't help for your problem... I understand.

I can't find any hints in the documentation on why AuthenticateAsClientAsync can behave differently.

Same for me

On the other hand AuthenticateAsClient perfectly works.

So, in the end, we should perhaps simply use AuthenticateAsClient on the SyncClient in all cases? I think so.

And if that were so, why do we actually think we need to turn SSL Buffering off (at least, in the SYNC client)? Looks like some testing is in order.

from fluentftp.

Well the decision is up to the author I think here.
I can confirm the following:

1. Buffering is off for me.

2. AuthenticateAsClientAsync hangs forever looks like (without CancellationToken timeout).

3. AuthenticateAsClient after 15 seconds (ReadTimeout) throws IOException with inner SocketException with the message: Unable to read data from the transport connection: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond..

4. AuthenticateAsClientAsync can still be cancelled with a cancellation token.

5. Inside ActivateEncryptionAsync AuthenticateAsClientAsync is called with provided CancellationToken for .NET >5 which is how it should be. But note that again Token should be cancelled explicitly as ReadTimeout won't be respected.

from fluentftp.

There is no provision for CancellationToken(s) in the entirety of the SyncClient. Thus using AuthenticateAsClientAsync seems problematic, so much for that.

So two open problems, in my mind:

SyncClient: Remove usage of AuthenticateAsClientAsync overall.
AsyncClient: Need to somehow respect ReadTimeout if .NET > 5.

from fluentftp.

I would like you to test the current master as to the problems you reported. I have just merged a first take on the SYNC side of this topic. Can do?

from fluentftp.