Prevent ever-growing stylesheet about fela HOT 9 CLOSED

@steida Yeah exactly. e.g.

const rule = props => ({
  position: 'absolute',
  // assuming it passes the scrollTop on every 'scroll' event
  top: props.scrollTop
})

Another one would be: Having sth. like a parallax page with 10000 elements and a lot of dynamic rendering on run-time. You might get thousands of classes though only 100 are used at the same time.
This is nothing that only happens to Fela, but is even more problematic with static CSS files.

We might want to have some options for the user to decide when to terminate styles, but yet I do not see any advantage yet. :P

from fela.

Why not leverage componentWillMount and componentWillUnmount methods?

from fela.

@steida First of all, this is a general "issue" (not really an issue though) so we're not only talking about the React world.

Also we would have to track the number of rendered components to safely remove classes only if the last instance gets unmount. A component that shares the same Fela rule might be rendered multiple times. But if you remove the class (especially the static one) if the first gets unmount, the others would loose there style.

It might not be a problem to track instances at all, but I don't see any advantage as well. I had no problem with growing stylesheets in any of my projects.

from fela.

I see, can you explain please when exactly to stylesheets grows? For example, wrong usage in animation?

from fela.

Also we would have to track the number of rendered components to safely remove classes only if the last instance gets unmount.

That's what we need to do I suppose.

from fela.

I guess we need to check if this is performant at all, compared to just keep the styles.

from fela.

I think it's the right behaviour anyway. When any component is removed, its style should be removed as well.

from fela.

You cannot treat CSS classes same as components. As every component instance is 1-1 relation while CSS classes are 1-many. So we can only safely remove the class if the last component instance using that class is unmount. (Though I guess that's what you meant anyways)

from fela.

@rofrischmann I assume that's what @steida meant - reference counting. If we did that, how would we account for dynamic rules? We would somehow have to tag them with the name of the component they are used for in order to be able to remove them later?!

from fela.