SSHLibrary not working with RF#5.0a1 about sshlibrary HOT 7 CLOSED

This issue is due to SSHLibrary using Robot's Python 2/3 compatibility layer. RF 5.0 doesn't need it anymore itself, but we have preserved it to avoid breaking libraries and tools using it (robotframework/robotframework#4150).

The problem is that SSHLibrary imports the PY2 constant from robot.utils.platform, but we have preserved it only in robot.utils. It was there also earlier, all utils that are part of the public API are exposed via robot.utils, so to fix this in a way that's compatible also with older RF versions you just need to change

from robot.utils.platform import PY2

to

from robot.utils import PY2

It would be great if you could do that soon and test how SSHLibrary in general works with RF 5. If there's something we have broken, let as know ASAP and we hopefully can still fix it before the final RF 5.0 release.

Ping @mihaiparvu.

from sshlibrary.

So far it seems the only problem was the old Python 2/3 compatibility layer. After making the fix and testing everything works as expected.

from sshlibrary.

I also tested this in my environment and didn't see any problem other than reported one here.

thanks!

from sshlibrary.

Great, thanks for testing! I checked the PR and noted that also WINDOWS could be imported directly from robot.utils.

from sshlibrary.

robot.utils.platform.PY2 was added back. The next RF 5.0 preview release ought to thus work with the current SSHLibrary version.

from sshlibrary.

What's the schedule for dropping Python 2.7 (and indeed EOL 3.4-3.6) in SSHLibrary?

from sshlibrary.

Please see PR #407 for an alternate compatibility fix.

from sshlibrary.