Giter VIP home page Giter VIP logo

Comments (9)

mnmaraes avatar mnmaraes commented on June 8, 2024

Funnily enough, if I use vim to open the local html files generated by cargo doc, they're complete. So this couldn't be an issue with the page's js not running

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

Thank you for the report, I will take a look at this tomorrow.

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

Sorry, took a bit longer than I would have liked to get to it. I just tried rebuilding cargo-docset with the latest stable and generating a docset for tokio and opening it in Zeal, it seems to work, so we have a different behaviour between Zeal and Dash.

I had the same hunch as you did and figured it must be some javascript not running. That's where it gets weird, even when disabling all javascript it my browser, I get something more complete than that. I still think this is JS related, but... Weird.

The only idea I have is this. I haven't needed it so far, but please try removing the docset from dash, adding the line <key>isJavaScriptEnabled</key><true/> to the generated info.plist within the property dict and reinstalling the docset. If it fixes it, I'll update the generated info.plist file. If it doesn't, please post the full info.plist file you modified for me to double check.

from cargo-docset.

mnmaraes avatar mnmaraes commented on June 8, 2024

Yep. Adding the .plist entry has fixed the issue

Good catch! Thanks

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

Okay, will add the entry and publish a new release shortly. Thank you :)

from cargo-docset.

saskenuba avatar saskenuba commented on June 8, 2024

Weirdly enough I have the same issue even with the js fix applied, but on Zeal(git master). For a struct, the methods and traits sections are not rendered. And for the traits pages, there is this "Loading Content" message. But if I just right-click to open with desktop browser they fully show up.

The crate tested was: ws-rs, perhaps you can test it on your side?

Upon some investigation, I renamed rustdoc.css on <crate>.docset/contents/resources to something else, and the whole document rendered. My best guess is that the browser engine used on zeal is outdated (maybe those flexboxes classes used on the CSS?) because apparently they are having other issues related to rendering.

The rust docs available for download on zeal have the display: block at the sections I mentioned, instead of the display: flexbox.

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

Sorry, I've been AWOL for a 'little' while and just noticed this. I'll try and verify this in the coming days.

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

I can indeed verify this using Zeal v0.6.1, and renaming rustdoc.css indeed gets the section to render (although it mangles the document pretty bad). I'll search for a workaround.

from cargo-docset.

Robzz avatar Robzz commented on June 8, 2024

This seems to be fixed in Zeal master 🎉 Most likely fixed by zealdocs/zeal#1125.

from cargo-docset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.