Comments (14)
pjebs
commented on May 28, 2024
Let me adjust it
from electron-alert.
pjebs
commented on May 28, 2024
What do you want done
from electron-alert.
ZIMkaRU
commented on May 28, 2024
sorry for waiting for an answer, missed this
so I have just checked this alert with electron v12 and v13 and it works if add contextIsolation: false flag to webPreferences of BrowserWindow options: https://github.com/rocketlaunchr/electron-alert/blob/master/src/alert.js#L288
info: electron/electron#23506 (comment)
I can send a PR if you want
from electron-alert.
ZIMkaRU
commented on May 28, 2024
sent a PR #11
from electron-alert.
ZIMkaRU
commented on May 28, 2024
from electron-alert.
pjebs
commented on May 28, 2024
I'll look at this in a few days
from electron-alert.
ZIMkaRU
commented on May 28, 2024
Thanks
from electron-alert.
pjebs
commented on May 28, 2024
Thanks for your contribution.
from electron-alert.
pjebs
commented on May 28, 2024
Let me know if you are happy with changes.
from electron-alert.
pjebs
commented on May 28, 2024
The library needs to be update to reflect v11 sweet alart 2 API. They have remove the v8 documentation online.
from electron-alert.
ZIMkaRU
commented on May 28, 2024
Let me know if you are happy with changes.
confirm, changes work fine for me on electron v13
from electron-alert.
pjebs
commented on May 28, 2024
I'll be modifying API soon.
from electron-alert.
ZIMkaRU
commented on May 28, 2024
Great, would be nice to do it with major version to have time to apply new api changes
from electron-alert.
pjebs
commented on May 28, 2024
What other improvements and features should I add/make?
from electron-alert.
Related Issues (12)
- [Feature Request] Add options to inject css style HOT 5
- Electron alert not working in electron": "15.1.1" HOT 3
- Position toast with respect to window not desktop
- bwOptions title fix HOT 1
- Font family ignored in title (or html) properties for swalOptions HOT 22
- Problem with Menu HOT 2
- Feature request: clean stack
- implement preConfirm
- globalShortcut.registerAll is not a function HOT 11
- Toast positioning HOT 13
- allowOutsideClick option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-alert.