Giter VIP home page Giter VIP logo

Comments (4)

Hooverdan96 avatar Hooverdan96 commented on July 17, 2024 1

Sounds good. I will create a PR for updating the documentation. I will do that as soon as I have worked out (or abandoned :) ) the Vagrant approach in the next few days. If I figure it out, I will create a separate issue/PR for that naturally, but that should inform this Issue as well.

from rockstor-installer.

phillxnet avatar phillxnet commented on July 17, 2024

@Hooverdan96 Thanks for reporting this. Much appreciated. I'm currently favouring your:

The vagrant update I am working on would switch to using the build box approach and essentially just add the step of copying from within the VM into the shared directory at the end of processing.

brute force approach. This is more a 'keeping it simple' approach if that can even be a thing with a virtual host mount within a VM building an OS installer using another VM 'box'. This way we depend on less 'special' options and go more with the flow of what works now and is likely less brittle to the changing nature of whatever tec is used to present the shared host fs.

As per the doc entry we could simply state this limitation of the boxbuild method with the associated copy requirement as a limitation, linking to your sited kiwi-ng doc section. In the scope of things the extra space requirement is not that much. I have in my notes to leave 5 to 6 GB of free space for a fresh installer build. I think it took around 3.5 GB when I last measured it. Plus we already indicate within the readme "... 15 GB free space ...".

from rockstor-installer.

Hooverdan96 avatar Hooverdan96 commented on July 17, 2024

Feel free to suggest other ways to document this.

from rockstor-installer.

phillxnet avatar phillxnet commented on July 17, 2024

@Hooverdan96 You pr is great. Thanks. I've now reviewed with a minor change suggested.

Re moving to semantic formatting. We already do this in our website material and post my review I realised we haven't gone that way yet here in the readme.md. But lets see how it looks in GitHub anyway (as a mix) and we can later move the entire readme whole-sale if it renders OK. I think it makes for easier edits/additions as it provides better 'chunking' and avoids messing about with more formatting that need be. And helps to keep line length down of course. I also like to see the overview of sentence, major part there of, length. See what you think.

from rockstor-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.