Giter VIP home page Giter VIP logo

Comments (10)

phillxnet avatar phillxnet commented on August 16, 2024 2

@FroggyFlox Thanks to seeing to this issue:

This repo is provided in the base Leap 15.5 Minimal VM image, however, so that's an argument in favor of including it.

Agreed.

@phillxnet , @Hooverdan96: your thoughts on including that repo for our Leap 15.5 profiles?

Similarly I'm also not of a strong opinion, and as you say it's not 'normally' relevant to us: however we do try to stick to upstream as much as possible - and if this repo is in our upstream we should likely include it identically also: just in case something breaks along-the-way as a result of upstream including this repo: even in a Minimal/JeOS image. So I'd actually lightly come down on the side of stick to upstream default repos as we then don't drift too far from what some packages may assume to be available. I.e. it has little overhead being there, and we may break something (possible down the line) in removing it. And we then have a side-by-side similarity with upstream with only our own additions: no subtractions.

from rockstor-installer.

phillxnet avatar phillxnet commented on August 16, 2024 2

@FroggyFlox Re:

Moreover, given Leap 15.5 is expected to be maintained until the end of December 2024 (https://en.opensuse.org/Lifetime#openSUSE_Leap), we should consider promoting it as default base OS (was Leap 15.4).

I propose that we drop 15.4 pretty soon after it reaches EOL actually, and yes, we now favour 15.5 as our preferred target. I'd like to get folks in the testing channel to the end of the current phase where they to still be on 15.4, but I do not propose to build stable rpms for 15.4 any longer give our next stable phase will begin after EOL for 15.4 anyway. But leaving the profile in place for a while could help folks who still have machines where 15.5 is problematic. However we have limited resources to manage too many targets so the EOL marker is a clear one to drop the targets we do try to manage. However we are already behind in this repo and are now only just dropping 15.3 (which you just presented earlier today :) ) so this is evidence that we need to reign-in our target range. Plus we have 15.6 around the corner so yes, lets drop 15.4 profiles entirely once we approach our next stable phase.

from rockstor-installer.

FroggyFlox avatar FroggyFlox commented on August 16, 2024 2

OK, so for now I have the following resulting repos in x86_64 Leap 15.5:

localhost:~ # zypper lr -U -p
# | Alias                              | Name                                                                                        | Enabled | GPG Check | Refresh | Priority | URI
--+------------------------------------+---------------------------------------------------------------------------------------------+---------+-----------+---------+----------+----------------------------------------------------------------------------------------
7 | repo-openh264                      | repo-openh264                                                                               | Yes     | (r ) Yes  | Yes     |   99     | http://codecs.opensuse.org/openh264/openSUSE_Leap
8 | repo-sle-debug-update              | Update repository with debuginfo for updates from SUSE Linux Enterprise 15                  | No      | ----      | ----    |   99     | http://download.opensuse.org/debug/update/leap/15.5/sle/
1 | Leap_15_5                          | Leap_15_5                                                                                   | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/distribution/leap/15.5/repo/oss/
6 | repo-backports-update              | Update repository of openSUSE Backports                                                     | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/update/leap/15.5/backports/
5 | repo-backports-debug-update        | Update repository with updates for openSUSE Leap debuginfo packages from openSUSE Backports | No      | ----      | ----    |   99     | http://download.opensuse.org/update/leap/15.5/backports_debug/
9 | repo-sle-update                    | Update repository with updates from SUSE Linux Enterprise 15                                | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/update/leap/15.5/sle/
3 | home_rockstor                      | home_rockstor                                                                               | Yes     | (r ) Yes  | Yes     |  105     | https://download.opensuse.org/repositories/home:/rockstor/15.5/
4 | home_rockstor_branches_Base_System | home_rockstor_branches_Base_System                                                          | Yes     | (r ) Yes  | Yes     |   97     | https://download.opensuse.org/repositories/home:/rockstor:/branches:/Base:/System/15.5/
2 | Leap_15_5_Updates                  | Leap_15_5_Updates                                                                           | Yes     | (r ) Yes  | Yes     |   99     | https://download.opensuse.org/update/leap/15.5/oss/

from rockstor-installer.

Hooverdan96 avatar Hooverdan96 commented on August 16, 2024 2

I'm aligned with the "stick closely to the upstream" especially since this does not really add anything material to the base footprint, if included.

from rockstor-installer.

FroggyFlox avatar FroggyFlox commented on August 16, 2024 1

Following the same repository "logic" that we currently follow for Leap 15.4, this results in an installer (for x86_64) that has the following repos:

localhost:~ # zypper lr -U -p
# | Alias                              | Name                                                                                        | Enabled | GPG Check | Refresh | Priority | URI
--+------------------------------------+---------------------------------------------------------------------------------------------+---------+-----------+---------+----------+----------------------------------------------------------------------------------------
7 | repo-sle-debug-update              | Update repository with debuginfo for updates from SUSE Linux Enterprise 15                  | No      | ----      | ----    |   99     | http://download.opensuse.org/debug/update/leap/15.5/sle/
1 | Leap_15_5                          | Leap_15_5                                                                                   | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/distribution/leap/15.5/repo/oss/
6 | repo-backports-update              | Update repository of openSUSE Backports                                                     | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/update/leap/15.5/backports/
5 | repo-backports-debug-update        | Update repository with updates for openSUSE Leap debuginfo packages from openSUSE Backports | No      | ----      | ----    |   99     | http://download.opensuse.org/update/leap/15.5/backports_debug/
8 | repo-sle-update                    | Update repository with updates from SUSE Linux Enterprise 15                                | Yes     | (r ) Yes  | Yes     |   99     | http://download.opensuse.org/update/leap/15.5/sle/
3 | home_rockstor                      | home_rockstor                                                                               | Yes     | (r ) Yes  | Yes     |  105     | https://download.opensuse.org/repositories/home:/rockstor/15.5/
4 | home_rockstor_branches_Base_System | home_rockstor_branches_Base_System                                                          | Yes     | (r ) Yes  | Yes     |   97     | https://download.opensuse.org/repositories/home:/rockstor:/branches:/Base:/System/15.5/
2 | Leap_15_5_Updates                  | Leap_15_5_Updates                                                                           | Yes     | (r ) Yes  | Yes     |   99     | https://download.opensuse.org/update/leap/15.5/oss/

For comparison, a Leap 15.5 Minimal VM (https://download.opensuse.org/distribution/leap/15.5/appliances/openSUSE-Leap-15.5-Minimal-VM.x86_64-kvm-and-xen.qcow2) base install has (debug repos were manually removed for clarity):

localhost:~ # zypper lr -U
Repository priorities are without effect. All enabled repositories share the same priority.

# | Alias                 | Name                                                         | Enabled | GPG Check | Refresh | URI
--+-----------------------+--------------------------------------------------------------+---------+-----------+---------+------------------------------------------------------------------
3 | repo-openh264         | Open H.264 Codec (openSUSE Leap)                             | Yes     | (r ) Yes  | Yes     | http://codecs.opensuse.org/openh264/openSUSE_Leap/
2 | repo-non-oss          | Non-OSS Repository                                           | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/distribution/leap/15.5/repo/non-oss/
4 | repo-oss              | Main Repository                                              | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/distribution/leap/15.5/repo/oss/
1 | repo-backports-update | Update repository of openSUSE Backports                      | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/update/leap/15.5/backports/
7 | repo-update-non-oss   | Update Repository (Non-Oss)                                  | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/update/leap/15.5/non-oss/
6 | repo-update           | Main Update Repository                                       | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/update/leap/15.5/oss/
5 | repo-sle-update       | Update repository with updates from SUSE Linux Enterprise 15 | Yes     | (r ) Yes  | Yes     | http://download.opensuse.org/update/leap/15.5/sle/

The only difference is thus the recent repo-openh264. As a reminder, this repo was added in partnership with Cisco to provide the h264 codec:
https://news.opensuse.org/2023/01/24/opensuse-simplifies-codec-install/
https://codecs.opensuse.org/openh264/
it provides, for Leap and Tumbleweed, in aarch64 and x86_64 archs (among others):

  • gstreamer-1.20-plugin-openh264-1.20.3-1.sle150500.2.x86_64.rpm
  • libopenh264-7-2.3.1-2.sle150500.2.x86_64.rpm
  • libopenh264-devel-2.3.1-2.sle150500.2.x86_64.rpm
  • mozilla-openh264-2.3.1-2.sle150500.2.x86_64.rpm

Codecs aren't my expertise but in my understanding, these would be only required to consume H264 media so this repo may not be needed for a NAS appliance such as Rockstor. Using Rockstor as a media server would be covered by our Rock-Ons so having these libraries on the base OS may not be relevant as that would be the Rock-On responsibility.

This repo is provided in the base Leap 15.5 Minimal VM image, however, so that's an argument in favor of including it.

@phillxnet , @Hooverdan96: your thoughts on including that repo for our Leap 15.5 profiles?
Personally, I don't have any strong opinion one way or the other but I would lean towards not including it as that's always one less repo to refresh for zypper.

from rockstor-installer.

FroggyFlox avatar FroggyFlox commented on August 16, 2024 1

Thanks a lot, @phillxnet and @Hooverdan96 for the prompt input here.
I'll add that repo to the profiles, then.
I still need to test and verify the Pi4 and ARM64 profiles so I'll update this issue accordingly once I get time to test that.

from rockstor-installer.

phillxnet avatar phillxnet commented on August 16, 2024 1

@Hooverdan96 Re:

curious, is that something that also needs to affect the rpmbuild repo, or is that already taken care of there?

Not really, as Leap versions going back to 15.0 are reference similarly via this bit:

https://github.com/rockstor/rockstor-rpmbuild/blob/d6b0d84a7dd3515e82f7aa63db243f6ba6340e01/rockstor.spec#L56-L64

Although I'm not sure I understand your question actually :).

@FroggyFlox

Where we not going to add the Tailscale repo into all our profiles?
In order that we can accomplish the following pending Issue:

Pre-install Tailscale #142

Which would then be the addition of the tailscale package itself specified as something to build into the image. Maybe this repo addition makes more send to include into the Pre-install Tailscal issue itself.

from rockstor-installer.

Hooverdan96 avatar Hooverdan96 commented on August 16, 2024 1

Although I'm not sure I understand your question actually :).

After re-thinking that question, I am not either :). I was thinking of the rpmbuild as doing the same thing as an installer creating an iso, etc. but that of course is not correct, I think I need more coffee, brain not awake yet ...

from rockstor-installer.

FroggyFlox avatar FroggyFlox commented on August 16, 2024 1

Maybe this repo addition makes more send to include into the Pre-install Tailscal issue itself.

That's exactly what I had in mind:

  • keep this issue focused on adding Leap 15.5 profiles and keep the rest untouched.
  • add tailscale repo and package for all profiles in a PR dedicated to #142.

from rockstor-installer.

Hooverdan96 avatar Hooverdan96 commented on August 16, 2024

curious, is that something that also needs to affect the rpmbuild repo, or is that already taken care of there?

from rockstor-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.