Comments (5)
At the moment, I don't know how to auto-rename a step if its class has been renamed. I need to somehow "find out" the new name of the step, then copy its values over. I am open to suggestions on that.
Least I can do is mark the step has invalid and not cause any errors.
from issues.
I didn't inspected deeply how you store references to the step scripts but I believe Unity's serialization system allows to keep references after class renaming since I can see component renaming does not leads to the missing script error in Unity itself.
Are you using Unity's serialization to track references to the steps?
BTW marking step as invalid already looks totally fine to me, though it still will be very painful to lose all configured settings of all renamed step instances =(
from issues.
Are you using Unity's serialization to track references to the steps?
I am using OdinSerializer for serialization.
BTW marking step as invalid already looks totally fine to me, though it still will be very painful to lose all configured settings of all renamed step instances =(
Thing is, how often do you rename Step class names? If you want to change the display name of the step, you can use a Name
attribute in StepDescription
instead.
from issues.
I am using OdinSerializer for serialization.
Ah, I'm not sure how they handle such case, never worked with Odin serializer before =\
Thing is, how often do you rename Step class names? If you want to change the display name of the step, you can use a Name attribute in StepDescription instead.
Thank you for this tip, but in my case class rename was needed to keep proper architecture of my custom steps (e.g. I created Step1 with some functionality but later I found that I need similar step with some additional features so I needed to rename Step1 to SimpleStep1 \ BaseStep1 etc.).
Also it's a common practice to rename classes during refactoring phase in order to give them more clear and meaningful names if it was not done initially.
I'm afraid without renamed classes reference tracking you may have more similar bug reports in the future since it's a default behaviour in Unity - to keep reference of renamed classes.
from issues.
I would need to get in touch with Odin Serializer development team to discuss this issue. At the moment, I am not confident that this would be fixed in 1.0.3.
from issues.
Related Issues (20)
- Copied variables bank does not opens in another Unity version with null reference errors HOT 6
- Variable bank does not save when you finish editing variables HOT 1
- Getting exceptions spam in console from Job Session Log window after project reopen HOT 3
- [Duplicating a Job and using it as a RunJob triggers an error] HOT 1
- [Low Prio] [Feature]: JobSession Log selects the Step on the Job Editor HOT 2
- [Low Prio QoL] Drag and Dropping a Job asset to the editor creates a RunJob Step HOT 1
- [RunJob - Maybe not a Bug] The External Variables have to be referenced on the parent that executes RunJob. HOT 2
- [OS X] Directory Paths: Can't resolve ~/ to user path HOT 1
- [Root Vars] Application version and Build Number HOT 4
- [High] Running a Loop on a Job trigger by another Job bugs HOT 7
- [Blocker Bug] Clicking on External and creating a Var Bank breaks Run Job's TargetJob Field HOT 1
- [Feature] Path selector button HOT 1
- Null Reference Exception on RunJob from CLI
- RunJob ignore content when called from CLI
- Modified on runtime VariableBanks aren't dirty, and cant be saved without edit. HOT 2
- Somechanges in Job Editor doesn't make JobAsset Dirty so changes aren't saved on Git HOT 1
- Variables Created inside RunJob aren't Available outside Job without storing them in Bank HOT 1
- MakeTextListStep output saved to VariableBank Field throw exceptions HOT 1
- Variable Bank List - Add Scroll HOT 2
- [Feature] Script Field for Steps (for easier access) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from issues.