Giter VIP home page Giter VIP logo

Comments (5)

ElmarTalibzade avatar ElmarTalibzade commented on July 21, 2024

At the moment, I don't know how to auto-rename a step if its class has been renamed. I need to somehow "find out" the new name of the step, then copy its values over. I am open to suggestions on that.

Least I can do is mark the step has invalid and not cause any errors.

from issues.

DmitriyYukhanov avatar DmitriyYukhanov commented on July 21, 2024

I didn't inspected deeply how you store references to the step scripts but I believe Unity's serialization system allows to keep references after class renaming since I can see component renaming does not leads to the missing script error in Unity itself.

Are you using Unity's serialization to track references to the steps?

BTW marking step as invalid already looks totally fine to me, though it still will be very painful to lose all configured settings of all renamed step instances =(

from issues.

ElmarTalibzade avatar ElmarTalibzade commented on July 21, 2024

Are you using Unity's serialization to track references to the steps?

I am using OdinSerializer for serialization.

BTW marking step as invalid already looks totally fine to me, though it still will be very painful to lose all configured settings of all renamed step instances =(

Thing is, how often do you rename Step class names? If you want to change the display name of the step, you can use a Name attribute in StepDescription instead.

from issues.

DmitriyYukhanov avatar DmitriyYukhanov commented on July 21, 2024

I am using OdinSerializer for serialization.

Ah, I'm not sure how they handle such case, never worked with Odin serializer before =\

Thing is, how often do you rename Step class names? If you want to change the display name of the step, you can use a Name attribute in StepDescription instead.

Thank you for this tip, but in my case class rename was needed to keep proper architecture of my custom steps (e.g. I created Step1 with some functionality but later I found that I need similar step with some additional features so I needed to rename Step1 to SimpleStep1 \ BaseStep1 etc.).

Also it's a common practice to rename classes during refactoring phase in order to give them more clear and meaningful names if it was not done initially.

I'm afraid without renamed classes reference tracking you may have more similar bug reports in the future since it's a default behaviour in Unity - to keep reference of renamed classes.

from issues.

ElmarTalibzade avatar ElmarTalibzade commented on July 21, 2024

I would need to get in touch with Odin Serializer development team to discuss this issue. At the moment, I am not confident that this would be fixed in 1.0.3.

from issues.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.