libco #defines conflict with Qt about hip-cpu HOT 4 CLOSED

Thank you for filing this. Since that's a macro, namespacing won't really help much. Also, we're clients of libco so modifying it would be a last resort (although possibly desirable, ultimately, since this is a consequence of us using it as a header only / all inline library, which is a modification in and of itself). What I think can be done is something like this:

#if defined(section)
#undef section
#endif
#include <whatever_qt_file_leads_to_qstring.h_being_included>

from hip-cpu.

Hi Alex,

how about

#include "../../../../external/libco/libco.h"
#undef section

in fiber.hpp:24 ?

Works for me :)

from hip-cpu.

@franjesus yup, that works too and is cleaner, but I've convinced myself that having a macro squat on such a common name is a faux pas, so I'll bite the bullet and just rename the macro to LIBCO_SECTION (other libco macros are similarly "namespaced", to it should be possible to have this upstreamed eventually).

from hip-cpu.

Thanks! makes sense

from hip-cpu.