Giter VIP home page Giter VIP logo

Comments (4)

emankov avatar emankov commented on July 26, 2024

Can the following suit your needs?

Having not found or multiple LLVM instances, the root folder with LLVM distributive must be specified in the CMake command line to build hipify-clang, for example:

-DCMAKE_PREFIX_PATH=/usr/llvm/17.0.6/dist

https://github.com/ROCm/HIPIFY/blob/amd-staging/docs/hipify-clang.md#hipify-clang-building

from hipify.

AngryLoki avatar AngryLoki commented on July 26, 2024

@emankov , sorry, I missed this part in the readme and both of these solutions work:

-DCMAKE_PREFIX_PATH=/usr/lib/llvm/17/lib64/cmake/llvm

or

-DLLVM_DIR=/usr/lib/llvm/17/lib64/cmake/llvm

So adding version in find_package could help, but it is not the only solution.

from hipify.

emankov avatar emankov commented on July 26, 2024

OK, thanks for your response!

So adding version in find_package could help, but it is not the only solution.

We can't stick with a particular version or a range while finding LLVM, as older versions may be installed depending on the user's platform. Choosing the latest version by default is a common and generally accepted behaviour of find_package; otherwise, the user must explicitly specify the needed version.

from hipify.

AngryLoki avatar AngryLoki commented on July 26, 2024

After thinking a bit more, I agree with you. At any point of time you can't control, in which next LLVM release compatibility will be broken and in the past won't be able to release HIPIFY in rocm-5.7.1 with find_package(LLVM 17 REQUIRED), as you can't say now that current version will be compatible only with LLVM 19 (and not LLVM 20).

from hipify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.