Add basic support for including devices basic on the generic device categories. In case specific version is not in the devicetypes file. about isy-js HOT 3 CLOSED

@robwbartel

Latest change a39beb2 now includes the initial version of this.

Note that the device categories didn't turn out to be as clean as one would like. For instance fans appear in category 2 even though they are not a dimmable light. I would expect the fan to appear in a different category and it's light to appear in the dimmable light category. (Both appear as lights).

So I implemented it as using the config file as primary and falling back to the generic code as secondary. As the code improves might be able to eliminate the file completely.

If you get a chance try it against your network see how well it identifies devices and let me know. It completely handles my network obviously but would like to hear how it does against others.

from isy-js.

I agree that was the best you could do. I didn't study it carefully, but the device identification stuff looked kind of haphazard to me so I wasn't expecting anything perfect. What I was hoping was that the Insteon folks would have a REST API or something to a database of their products with generic capabilities each has.

In any event, your changes seem to work great for my network - e.g. it appears to get my 10-year old Icon devices right.

from isy-js.

@robwbartel Thanks for confirming. Glad to hear it is working for you.

from isy-js.