Giter VIP home page Giter VIP logo

Comments (8)

roginfarrer avatar roginfarrer commented on May 25, 2024

Can you provide a codesandbox example? Or some steps to reproduce? Which version?

from collapsed.

 avatar commented on May 25, 2024

@roginfarrer Can't, cause I received TypeError: Cannot read property 'useMemo' of undefined every time, when i tried to use your library in code sandbox

from collapsed.

roginfarrer avatar roginfarrer commented on May 25, 2024

Sounds like you don't have React installed. The library requires React v16.8.x.

Here's a codesandbox demo

from collapsed.

roginfarrer avatar roginfarrer commented on May 25, 2024

Closing due to inactivity.

from collapsed.

saranchonkau avatar saranchonkau commented on May 25, 2024

The same bug!
We can easily reproduce it by adding padding to container that receives collapse props.
I tried it with basic demo on your demo site

image

from collapsed.

roginfarrer avatar roginfarrer commented on May 25, 2024

I think this is related to challenges measuring the element with padding applied. Will need to dig in further.

from collapsed.

Sandstedt avatar Sandstedt commented on May 25, 2024

A quick fix is to apply padding to the child element instead.
<section {...getCollapseProps()}><div style={{ padding: 20 }}>{props.children}</div></section>

from collapsed.

roginfarrer avatar roginfarrer commented on May 25, 2024

I'm thinking the solution here is just to document this limitation and add a console.warn if the padding property is passed to the Collapse. I looked into getting the vertical padding when measuring the element's dimensions via window.getComputedStyle, but that operation is costly, and still doesn't give a smooth closing transition (the transition ends at the element's sum of the top and bottom padding, not 0). As @Sandstedt said, the best solution here is to apply padding to the children instead.

from collapsed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.