Explicit input validation on the server about pityoulish HOT 5 CLOSED

Funny side effect: The ticket manager does not check the characters in the username. You can obtain tickets for username " ", for example. Of course, the ticket will also contain the whitespace from the username.

from pityoulish.

The initial implementation of the Message Board server with Java RMI will also rely on implicit validation of arguments. To be fixed with this issue as well.

from pityoulish.

How to handle null checks? Should these be part of the sanity check, and return a problem description? Or should the checks only be called for non-null arguments?

As of now, the DefaultMSanityChecker and DefaultTSanityChecker are inconsistent in this regard. They throw NullPointerException for missing mandatory arguments, instead of returning an error description. But DefaultMSanityChecker tolerates a null marker, because that's an optional argument.

It might be better to leave it to the caller whether an argument is optional. Then it would make sense for the checkers to require non-null arguments and throw exceptions for null. Or to report a missing argument as invalid.

from pityoulish.

As for optional arguments, the caller has to handle that. Sanity checkers will complain about null arguments. I'm still not sure whether I should throw an exception or report as missing. For now, an exception is thrown.

from pityoulish.

It's good enough for now. See #53 and #55 for what else could be done in this area. Help is welcome!

from pityoulish.