Giter VIP home page Giter VIP logo

Comments (4)

obiwankennedy avatar obiwankennedy commented on August 19, 2024

Should be fixed.

from diceparser.

ditto13 avatar ditto13 commented on August 19, 2024

Confirmed ! Thanks!

Curious .. what was root issue ?

from diceparser.

obiwankennedy avatar obiwankennedy commented on August 19, 2024

DiceParser works like it is eating the command.
When it understands the first character, this character is removed from the command line.
And if it did not understand the rest of the command, it stopped the parsing and ran the command without displaying any warnings about "that part of the command has been ignored".
For example:
!1d6¿3
It would had understand 1d6, and run it but ¿3 would have been completely ignored, without user notification about it. So now, you are noticed when the whole command is not understand.

So i had management of that. At the end of the parsing step, if the command still contains characters that means not the whole command has been understood.
But the reading of comment did not removed the comment from the command line. I just fix the coment reading to remove the comment from the command.

from diceparser.

ditto13 avatar ditto13 commented on August 19, 2024

Ah, makes sense .. thanks for quick response and explanation! :)

from diceparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.