Comments (3)
Whoops. My understanding of [].sort
was way off the mark, thanks for the explanation. The intent was just to make sure that...
var a = 1;
export default a;
a = 2;
...would maintain the same order, since (due to the fact that export default a
isn't a live binding like export {a}
) it effectively needs to be rewritten as this:
var a = 1;
var _a = a;
a = 2;
It's a bit of a nuisance edge case (and rare, as far as I can see) but specs are specs. Ordinarily statements preserve the correct order naturally, but export default
trips things up.
I apologize if this is a distraction.
Far from it - being able to catch these things at this stage of the library's development is absolutely invaluable. I apologize for breaking your builds! Am working on a solution for this issue.
from rollup.
Okay, I've come up with what seems like a more appropriate solution - we have some special logic for dealing with cases like the above. Rather than attempting to reorder statements at a bundle level, the expansion of export default a
is modified in place (if necessary) such that the export declaration appears before any later statements from the same module. The d3-color tests now pass, so I've released this as 0.7.4 - feel free to reopen this issue if it turns out the bug isn't quite squashed.
from rollup.
Thanks. Looks good!
from rollup.
Related Issues (20)
- Replace glob.sync by globSync in code example HOT 4
- CJS re-export regression with externalLiveBindings: false HOT 1
- NodeJS Core Dump on Specific Syntax Error (`Prop::Assign`) HOT 9
- Missing known globals: WeakRef, FinalizationRegistry, AggregateError.
- Default option for hashCharacters is not adblock-safe HOT 1
- Assistance with Rollup export functions & default.
- Support for 32-bit Linux (x86/ia32)
- onLog documentation is lacking something HOT 2
- Provide format info in output.chunkFileNames callback HOT 1
- Why is rollup creating an additional file of just exports from my entry file? HOT 4
- When I use format: "es" & sourcemap: false, bundle.write outputs an es module and a systemjs module with a sourcemap HOT 1
- What has been upgraded “terser: 5.27.3” HOT 1
- Exceptional performance of `namespace import` object values
- Cannot figure out a good workflow for a Shopify site...
- Setting `moduleSideEffects: false` removes side effectful getter inside a exported function since 4.9.2 HOT 2
- Rollup incorrectly merging ESM and CJS modules resulting in missing exports
- Treeshake dynamic import of modules
- RollupError: Unexpected token `.`. Expected * for generator, private key, identifier or async HOT 3
- [dir] placeholder for `output.assetFileNames` HOT 3
- I get loads of 'Circular dependency' errors when bundling 'npm link' symlinked modules HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rollup.