Reordering is breaking statements with side-effects. about rollup HOT 6 CLOSED

Thanks. No need for a more isolated test, I reckon this is small enough to work with - will look into it as soon as I get a chance. Not immediately sure what's causing it but am sure it's fixable (he said confidently...)

from rollup.

@mbostock Turns out I'm struggling to reproduce this - all the d3-shape tests are passing for me, and the statement ordering looks to be correct. Has anything changed since this issue was opened?

from rollup.

Yeah, there’s a workaround I’ve been using.

I’ll try to pare down a standalone test case.

from rollup.

Here ya go:

https://gist.github.com/mbostock/bc1ffc78c3f933eff312

Note that if you reverse the order of statements in index.js, the test passes!

from rollup.

Ah, I see what's going on here. The (new Foo) line causes the Foo definition to be included, which means also including Foo.prototype.test = ... and (because rollup can't know that Object.create doesn't modify Foo.prototype) Bar.prototype = Object.create(Foo.prototype). So the second line, which causes the Bar declaration to be included, doesn't include the Bar.prototype = statement because it's already included.

Not immediately sure what a general solution looks like (the last time I tried to naively sort statements according to their original order, it ended badly), but I'll try a few things. Suggestions welcome!

from rollup.

Fixed in 0.9.0 - have confirmed all the d3-shape tests now pass without the workaround

from rollup.