Call to a member function error() on a non-object about feed-on-feeds HOT 6 CLOSED

Also similar lines:

PHP Notice: Uninitialized string offset: 0 in /var/www/classes/favicon.php on line 232

from feed-on-feeds.

At a cursory glance, the favicon notices would seem to be from a site specifying an empty URL as an icon. The two errors may be somehow related, but this one is probably ignorable for now..

However, the error() error is certainly odd, and more interesting -- my first read of it as suggests that either fof_parse(), or SimplePie itself, is returning a something which is not a SimplePie class.. which would be very strange.. Don't really have a lot to go on, here. :)

Which commit are you running, what feed is generating that, and is there anything interesting in the fof.log from the start of an update of that feed until it fails?

from feed-on-feeds.

Oh, or maybe it was just failing to parse an empty feed url, and then tripping up on the error reporting because a false variable is still a set variable. Some quick fixes for both that case and to quiet the favicon notices are in my fork now, if you want to give them a try.

from feed-on-feeds.

@thylacine That's brilliant. Great catch, thats quelled the error() warning.

I forgot I had @silenced some lines in the favicon class.

[Tue Nov 19 13:17:49 2013] [error] [client 146.185.175.25] PHP Warning:  file_get_contents(http://www.thechessworld.com/images/favicon.ico): failed to open stream: HTTP request failed! HTTP/1.1 404 Component not found\r\n in /var/www/classes/favicon.php on line 170
[Tue Nov 19 13:17:49 2013] [error] [client 146.185.175.25] PHP Notice:  icon resource 'http://www.thechessworld.com/images/favicon.ico' returned 404 in /var/www/classes/favicon.php on line 177
[Tue Nov 19 13:17:50 2013] [error] [client 146.185.175.25] PHP Warning:  file_get_contents(http://rss.openobjects.com/favicon.ico): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found\r\n in /var/www/classes/favicon.php on line 170
[Tue Nov 19 13:17:50 2013] [error] [client 146.185.175.25] PHP Notice:  icon resource 'http://rss.openobjects.com/favicon.ico' returned 404 in /var/www/classes/favicon.php on line 177
[Tue Nov 19 13:18:04 2013] [error] [client 146.185.175.25] PHP Warning:  DOMDocument::loadHTMLFile(http://www.seo-theory.com/): failed to open stream: Connection refused in /var/www/classes/favicon.php on line 80
[Tue Nov 19 13:18:04 2013] [error] [client 146.185.175.25] PHP Notice:  Undefined variable: http_response_header in /var/www/classes/favicon.php on line 90

Would it be ok to just silence those lines or should a more purposeful ignore be written in the class so error logs are not filled (i mean filled - I have a user with 300 feeds alone)?

from feed-on-feeds.

I'm a little wary of totally ignoring these events -- some people (well, maybe only me :) ) might want to keep track of what's going on..
So, my solution would be to quell the remaining warnings, and re-route any notices (which are really just the anticipated warnings, rewritten) directly into the fof log, with a 'favicon' label, whence they can be ignored via the admin logging preferences.
I've just pushed a stab at this behavior to my fork, but it's not very tested yet..

from feed-on-feeds.

Closing because the issue has no updates for 5 years :)

from feed-on-feeds.