Giter VIP home page Giter VIP logo

Comments (3)

romantitov avatar romantitov commented on May 19, 2024

Hello @natehitze. Thank you for your feedback. I'm glad to see so impressive performance improvement. And your benchmark looks very processing. But we also need to take in to account real use cases, and make sure that that it works for test scenarios and for all mock frameworks.
If we can use TestAsyncEnumerableEfCore<T> instead of BuildMock() may I ask you just update existing unit tests in MockQueryable.Sample (as an option you can just change implementation of BuildMock extensions with your approach).
If will not be any side effects of usage TestAsyncEnumerableEfCore<T> and all tests will be green, I would be happy to include merge your pull request to the repository and update all nuget packages. In this case we even don't need to update documentation. I will also add a special thanks for you to release notes.

from mockqueryable.

natehitze avatar natehitze commented on May 19, 2024

Thanks! I did add a little bit to the README since I'm not sure I explained it very well in this issue but hopefully that change along with the PR description makes more sense.

from mockqueryable.

romantitov avatar romantitov commented on May 19, 2024

Thanks @natehitze for the PR but I expected a bit different changes. In spite of this I will include special thanks for you in the next release notes (release 5.0.2). Based on your suggestion I've made own PR #57 (it takes into account backward compatibility and tested by all existing changes). Unfortunately I cannot merge it to the repo.
Thanks for your contribution!

from mockqueryable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.