Comments (3)
Hello @natehitze. Thank you for your feedback. I'm glad to see so impressive performance improvement. And your benchmark looks very processing. But we also need to take in to account real use cases, and make sure that that it works for test scenarios and for all mock frameworks.
If we can use TestAsyncEnumerableEfCore<T>
instead of BuildMock()
may I ask you just update existing unit tests in MockQueryable.Sample
(as an option you can just change implementation of BuildMock
extensions with your approach).
If will not be any side effects of usage TestAsyncEnumerableEfCore<T>
and all tests will be green, I would be happy to include merge your pull request to the repository and update all nuget packages. In this case we even don't need to update documentation. I will also add a special thanks for you to release notes.
from mockqueryable.
Thanks! I did add a little bit to the README since I'm not sure I explained it very well in this issue but hopefully that change along with the PR description makes more sense.
from mockqueryable.
Thanks @natehitze for the PR but I expected a bit different changes. In spite of this I will include special thanks for you in the next release notes (release 5.0.2). Based on your suggestion I've made own PR #57 (it takes into account backward compatibility and tested by all existing changes). Unfortunately I cannot merge it to the repo.
Thanks for your contribution!
from mockqueryable.
Related Issues (20)
- Composite Primary Key HOT 3
- Can I use AddAsync and expect to have the result in the mocked DbSet? HOT 1
- After upgrade it does not work with EF.Functions.Like HOT 1
- Unable to mock result of IAsyncEnumerable from DbSet using NSubstitute HOT 2
- Write Entities HOT 2
- Parameterized Repository Query Issue HOT 1
- Set return value of FirstOrDefaultAsync method by NSubstitute returns error HOT 2
- ToListAsync() returns empty list after package update to 6.0.0 HOT 3
- how would I get firstordefaultasync working? HOT 1
- Typo in About section for project HOT 1
- Mocking AddAsync HOT 1
- Cannot verify "Remove" method called on EF HOT 1
- ToListAsync() returns empty list on second call HOT 3
- Return value of SaveChangesAsync HOT 1
- Not suported with EF7: ExecuteDeleteAsync and ExecuteUpdateAsync HOT 5
- Not suported with EF6: BulkUpdateAsync, BulkDeleteAsync, SingleUpdateAsync. HOT 1
- Modifying base collection throws System.InvalidOperationException HOT 3
- Does mocking SingleOrDefaultAsync not work for FakeItEasy ? HOT 1
- Supporting `EF.Functions.Like` and/or prossibility to provide cusotm `ExpressionVisitor` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mockqueryable.