Giter VIP home page Giter VIP logo

Comments (14)

Empact avatar Empact commented on August 16, 2024

I don't see why it would be appropriate to license roo under more restrictive terms just because one of our dependencies is restrictive. Particularly given that those who do not use XLS aren't affected.

I'm happy to mention spreadsheet's GPL licensing in the readme, feel free to submit a pull request to update it. Beyond that you're better off trying to convince spreadsheet to adopt a more liberal license.

from roo.

pabloh avatar pabloh commented on August 16, 2024

GLPv2 and GLP3 are compatible with the MIT/Expat License (http://gplv3.fsf.org/wiki/index.php/Compatible_licenses), I think this issue can be safely closed.

from roo.

Empact avatar Empact commented on August 16, 2024

Hey @pabloh I don't see MIT/BSD in the GPL3 list. Can you point it out for me?

from roo.

pabloh avatar pabloh commented on August 16, 2024

@Empact the MIT license is identical to the Expat license (http://directory.fsf.org/wiki/License:Expat , http://www.debian.org/legal/licenses/mit), which's inside the first list.

from roo.

Empact avatar Empact commented on August 16, 2024

Good to know, thanks.

Even so, I see that Expat is compatible with GPL2 but I only see the following for GPL3:

GPLv3-compatible licenses

These licenses are compatible with the GNU GPL version 3.
Apache Software License, version 2.0

from roo.

pabloh avatar pabloh commented on August 16, 2024

As far as I knew every license compatible with GPLv2 was also compatible with GPLv3.

Nevertheless, I just checked and it seems to be the case: http://www.gnu.org/licenses/quick-guide-gplv3.html

Bellow 'New Compatible Licenses' the following sentence can be found within that section's 2nd paragraph:
"...GPLv3 is compatible with just about everything GPLv2 is, and then some."

from roo.

sleeptillseven avatar sleeptillseven commented on August 16, 2024

@Empact I'm there with you. I would love spreadsheetto change to MIT, but they won't. They sell licences for companies who use spreedsheet but don't want to open source their code, which is good in a way, although not very cheap. So when discovering roo and it's free licensing we automatically switched to it, not seeing that it uses spreedsheet.

I will send a pull request with the respective mention of roo's underlying gems licences.

from roo.

sleeptillseven avatar sleeptillseven commented on August 16, 2024

My pull request #43 with respecitve code sleeptillseven@2a8b916

from roo.

Empact avatar Empact commented on August 16, 2024

Thanks!

from roo.

rui-castro avatar rui-castro commented on August 16, 2024

Hi @Empact,

Thanks for the great gem :)

I had the same problem as @sleeptillseven (even after reading the new text :S). My understanding of that sentence was that "...this gem is better than spreadsheet because it uses MIT license..."! English is not my native language :)

One important thing that should be mentioned in the README is that Roo depends on spreadsheet gem. It's not explicitly mentioned right now.

I've created a fork of this repo here that doesn't depend on spreadsheet gem (and doesn't support *.xls files) for people, like me, that don't need the support for *.xls.

from roo.

Empact avatar Empact commented on August 16, 2024

@rui-castro That sounds like a great solution. Splitting out a roo-xls gem would make a lot of sense particularly considering its legacy nature. I'll look at making this change and publishing the gem later this week. Thanks!

from roo.

rui-castro avatar rui-castro commented on August 16, 2024

@Empact great ;)

from roo.

Empact avatar Empact commented on August 16, 2024

I've done this now, but haven't released the gems yet - see roo-rb/roo-xls.

from roo.

rui-castro avatar rui-castro commented on August 16, 2024

@Empact nice. Thanks.

from roo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.