Giter VIP home page Giter VIP logo

Comments (6)

ellesmith88 avatar ellesmith88 commented on July 20, 2024

@agstephens I've looked at these tests and found that introducing these changes doesn't cause the aggregation to break. The tests show that if the change is made on the first file in the time series then the new netcdf file includes the change otherwise the change is ignored.

https://github.com/roocs/daops/blob/issue/8/xarray_agg_tests/tests/test_xarray/test_xarray_aggregation.py

If the change is made to all 3 there is an error - I'm still looking at this and making the files temporary.

from daops.

agstephens avatar agstephens commented on July 20, 2024

@ellesmith88: Do the statements above relate to all the different types of changes that are tested in test_xarray_aggregation.py?

from daops.

ellesmith88 avatar ellesmith88 commented on July 20, 2024

@agstephens Yes it does, just added a second test for changing var_id to show this.

from daops.

agstephens avatar agstephens commented on July 20, 2024

Thanks @ellesmith88, are there any arguments that we can set to force the behaviour to be stricter?

from daops.

ellesmith88 avatar ellesmith88 commented on July 20, 2024

@agstephens Sorry I just realised this isn't the case for var_id which actually creates a new variable so that new_var_id and old_var_id are both in ds.variables no matter which file is modified.

Looking at the arguments - haven't found anything that works yet.

from daops.

agstephens avatar agstephens commented on July 20, 2024

@ellesmith88: that seems like a logical response, that xarray would just load two separate variables.

from daops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.