Comments (26)
Complete oversight since I was doing some manual testing before adding this. I'll get it added.
from trellis.
No worries. I can submit a patch if you like!
from trellis.
Sure 👍
from trellis.
Also, what's the plan for memcached integration with roots/bedrock? Will there be any configuration added to that repo?
from trellis.
Not sure exactly. The not really well thought out plan was to at least make this playbook support a caching plugin out of the box since I think that's a requirement and don't want to leave it completely up the user.
I personally hate W3TC and don't love Super Cache either. That left an Nginx based caching solution, but I wasn't sure about the maturity of the plugins, and Batcache. So I added memcached for the purpose of using Batcache. Obviously any Bedrock based WP would need a few tweaks like including the plugin, advanced-cache.php
file (which is really annoying since it's not a normal plugin).
If you have thoughts pleas let me know!
from trellis.
Well, another question I have is how sold are you on integrating Memcache as opposed to Redis?
from trellis.
In my fork, I was going to go with Redis but then saw y'all added the memcached route, so I diverted as well to stick as close to y'all as possible.
from trellis.
I'm a Redis fan in general, but if you're not taking advantage of its data structures, I'd rather stick with memcached for just a dumb fast cache.
from trellis.
👍 works for me. I'm going to think more about what you asked earlier... I'll keep you posted!
from trellis.
And thanks for mentioning your fork. Looks like it has some useful things in there I was eventually going to do like SSL support so I'll take a look at it.
from trellis.
Sorry to butt in, but isn't Redis as fast/faster than memcached? Only chimed in because you both expressed preference for Redis
from trellis.
Absolutely! And I'll preface SSL specifically: it's a slight hack. Currently, Ansible and ansible-vault
don't have a way to decrypt files using the copy module, so I'm having to store certificates in a var file and encrypt the file. That feature is eventually going to be implemented, but until then...
from trellis.
@ckovey or @nathanielks is there an equivalent to Batcache that uses Redis? Without resulting to something like https://github.com/BenjaminAdams/wp-redis-cache. I don't like the idea of how it's setup with the index file changes.
from trellis.
@swalkinshaw @ckovey so far from what I've seen, no. There has to be some sort of interrupt because Redis will serve the page from memory, so it has to be loaded before WordPress is =\
from trellis.
@swalkinshaw @ckovey there is this: https://github.com/ericmann/Redis-Object-Cache, though when I was doing Redis research a while ago, it was still under development. That may have changed.
from trellis.
Aha! it's not! It would appear they've reached a functional 1.0
from trellis.
I'm a WP novice. We do Symonfy2 projects currently but I've been keeping my eye on roots for our company website.. so I'll leave the choice up to you as I'm not familiar with the ins and outs of wordpress plugins/compatibility with redis.
from trellis.
@ckovey I'm biased, but I'm a fan ;)
from trellis.
Well there's object cache and page cache.
@nathanielks theoretically an almost exact replica of Batcache but with some Redis changes could exist. There's no reason why you need that index file solution. Unless I'm just missing something. Batcache just takes advantage of of the Memcached Object Cache plugin/dropin, and since one exists for Redis now, it would work as well.
from trellis.
I figure then continue using Memcache + Batcache until someone does make a Redis Batcache, yeah? Unless you're feeling adventurous =p
from trellis.
Wanted to check in here as I'll finish up Memcache or start on Redis. Any word on which direction we should go with?
from trellis.
Redis is more clever, but if batcache works not sure if there is a great reason to try and find a more complicated alternative.
from trellis.
Let's just do Batcache for now. I'd only really consider a Redis based one if a Batcache-like plugin existed.
Aside: my personal preference is to use an Nginx based caching solution since 1) it's already installed, 2) it's good. Only issue is some of the Nginx caching plugins (which exist just to purge content) seem to have issues. There's potentially some more mature Varnish ones which would probably work fine since they all just do a purge http request.
Further aside: The bulk of most WP caching plugins are hooking into various events like "updating a post" and then purging the cache. This is a waste of time as everyone just duplicates efforts, has different bugs, or misses features like support custom types, etc. Smart thing to do would be to develop a base cache purging API which you could just implement in any plugin for cache front-ends like: Memcache, Redis, Nginx, Varnish, etc.
from trellis.
@swalkinshaw FYI, this issue can be closed, but before you do, I am curious why you hate W3TC. I've never used it, but I was getting New Relic set up on my sever (maybe something worth scripting in?), and I saw W3TC's NR integration, which reminded me that you didn't like it. Any reason why?
from trellis.
@mAAdhaTTah it's mostly just insanely bloated and does too many things. And most of the things it does there are better solutions meant specifically for them. W3TC is also made for people who 1) don't really know about caching and 2) are problem on a shared host or limited environment.
We can and should do better :)
from trellis.
Makes sense, thanks!
from trellis.
Related Issues (20)
- Bug: the role 'mailhog' was not found HOT 1
- Bug: MariaDB Serversetup skipped if we want to create multiple sites with remote db and local db
- Bug: `Check whether Ansible can connect as <user>` – passes when SSH connection fails HOT 2
- Bug: composer auth during wordpress install has loop var conflict HOT 1
- Bug: TLS 1.3 not working HOT 5
- Bug: latest curl version fails to retrieve urls on trellis managed hosts
- Feature Request: switch from ssmtp to msmtp
- Personal Data in Commit HOT 4
- Vagrant box with Ubuntu 22.04 on Apple silicon won't start HOT 2
- cron missing HOT 12
- 💡 Feature Request: Add ability to use vault pass lookup plugins by default. HOT 3
- PHP `8`: Enable `JIT` (`PHP` `INI` option) HOT 4
- Can't install galaxy dependencies on Python 3.12 HOT 1
- Officially support Ubuntu 24.04
- MariaDB 10.6.18 release requires action HOT 5
- `trellis up` fails with an "undefined method `exists?` for class File (NoMethodError)" error on new projects HOT 1
- `ansible-core:2.17` / Ansible 10 not supported HOT 5
- `nginx`: `http2` configuration deprecation notice HOT 11
- missing php_extensions_default when provisioning sshd HOT 4
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trellis.