Comments (4)
I understand that the unique equations that we want to identify are the unique values of equation_allometry
, right? Until we solve this permanently, would it work if I populate equation_id
with the values of equation_allometry
?
from allodb.
After removing duplicated rows from the equations
table, I still find that this table has more rows than unique values of equation_allometry
(relates to #48 ). Is this expected?
library(allodb)
equations_table <- as_allodb(equations)
# Not the same:
nrow(equations_table)
#> [1] 178
length(unique(equations_table$equation_allometry))
#> [1] 147
Created on 2018-09-26 by the reprex package (v0.2.1)
from allodb.
@maurolepore Maybe we need the equation_id before I start to test the splitted tables. It is too complicated right now, specially if I want to use the same equation for multiple sites.
I was thinking the equation_id could be something like first letter of genus+first letter of sp+number..for example, there are 4 equations for Acer rubrum, we could use acru_001, acru_002, acru_003, acru_004. I think equation_id should not be too long (ie. a 14 digit random number!).. so maybe the time stamp idea work best..
what do you think?
from allodb.
@gonzalezeb, I have updated the .csv database (233ef4c). Now the equations table has equation_id
s (see). I used random ids of 6 characters. Next time you add a new equation you could pick an id from data-raw/available_random_ids.csv
(here). I avoided ids that use info from other columns because if that info changes then the ids would be missleading. Take my choice as a suggestion. I'm happy to change the approach if you prefer something different.
Closing now but feel free to reopen.
from allodb.
Related Issues (20)
- Replace data.frame() with tibble()
- When calling stop() use call. = FALSE
- some commits not showing
- Increase test coverage
- Tidy allodb::equations in advance, not in new_equaions()
- Prune data-raw/ HOT 1
- Remember to review FIXME and TODO
- Simplify new_equations()
- Ensure error messages wrap nicely
- Remove needless calls to print() in examples
- Use simpler markdown syntax, e.g. replace \pkg{allodb} with *allodb*
- Review punctuation of helpfiles (title and other sections)
- Use simple comments to follow tidyverse styleguide "# blah" not "## blah"
- Reserve return() for early returns (tidyverse styleguide)
- Remove redundant reference to allodb
- Remove duplication in documentation
- Replace references to `f()` with [f()].
- Document default vaules in signature, not in `@param` or elsewhere
- If `coords` has wrong dimensions `get_biomass()` should throw an error HOT 2
- Support for the component ratio method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from allodb.