Giter VIP home page Giter VIP logo

Comments (3)

MohammedFCIS avatar MohammedFCIS commented on July 28, 2024

A note from ropen sci

I think the "Exploring the data" section is a little too heavy for README. This kind of contents is great in the getting started vignette but is not that useful in README as it is basically demonstrating dplyr and ggplot.

from dbparser.

MohammedFCIS avatar MohammedFCIS commented on July 28, 2024
  • I think it would help unfamiliar users to add another sentence in the introduction explaining what DrugBank is. It would also be helpful to include a note about the need to make an account and request access to the data.
  • Suggest removing commented code
  • It seems like you made some changes recently that are resulting in errors in the README, so I suggest combing through it to make sure it's working as expected. Below are a couple things I've noticed.
  • parse_drug_targets_actions() no longer works (it's now parse_drug_targ_actions()). Side note: I agree with @haozhu233 it would be nice to shorten some of the function names if possible.
    xml_db_name is not an argument in open_db()
  • As expected parse_drug(save_table = TRUE) (and all parse functions) throws an error when there is no database to save to. However, the error only happens after parsing the data for about a minute, so it would be nice to throw an early informative error to the user.
  • Make sure all relevant libraries are called for the plots (ggplot2, dplyr)
  • The package description in R help can use a bit of clarification. I'd suggest emphasizing the drug bank parser over the database functionality.

from dbparser.

MohammedFCIS avatar MohammedFCIS commented on July 28, 2024

Enhance db connection section as note below

Database
This may be due to inexperience on my part, but I was confused about how to save the database using the driver and server argument. I would have liked to be able to save it to a SQLite or other local database using DBI::dbConnect. Is it possible to make these functions more generalizable? Or at minimum, add more description of what type of databases the package supports?

from dbparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.