Giter VIP home page Giter VIP logo

Comments (12)

adamhsparks avatar adamhsparks commented on June 26, 2024 1

I think this is finally fixed, here and on a couple other repositories where I’ve tried it. Will wait another 24hrs to be sure and then close this.

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024 1

All good! No error messages today. Thanks for your assistance, @pat-s.

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

Right, thanks for that. I had a feeling I was missing something here but got sidetracked and didn't investigate further.

from gsodr.

pat-s avatar pat-s commented on June 26, 2024

Hi Adam, just wondering if something is still unclear since the update-tic action is still erroring due to the lack of the secret?

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

Is it? I thought it all ran fine.

tic::gha_add_secret(<secret>, "TIC_UPDATE")

Where <secret> was my GH PAT with a "workflow" scope. So, yes, I guess something wasn't clear to me because I thought it was working now. 😕

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

Ah, I fixed a different issue that I was having. Dang.

OK, no, it's not clear. Sorry, I don't understand what needs to be done here.

from gsodr.

pat-s avatar pat-s commented on June 26, 2024

The PR creation fails because you renamed your default branch from master to main: https://github.com/ropensci/GSODR/runs/974227217?check_suite_focus=true#step:6:100

Maybe updating the action helps (just run tic::use_update_tic()) again. If not, you need to set the new default branch name in the "create-pull-request" action manually.

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

OK, I just feel dumb. I know that the YAML, update-tic.yml, specifies "main" not "master" but it's still failing when I trigger a build.

I thought that I had even updated that before I even ran tic::use_update_tic() just now, but now I know for sure that I've done both and it still fails.

from gsodr.

pat-s avatar pat-s commented on June 26, 2024

I do not see it failing. Note that the action is only run once a day in cron job. Where do you see it failing?

LGTM on the first look.

from gsodr.

adamhsparks avatar adamhsparks commented on June 26, 2024

from gsodr.

pat-s avatar pat-s commented on June 26, 2024

You triggered a run for your main branch. This will not trigger a run for the update-tic YAML. The latter is configured CRON-only.

Let's wait for tmrw. Chances are that everything will just work then ;)

from gsodr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.