Giter VIP home page Giter VIP logo

Comments (6)

sckott avatar sckott commented on August 28, 2024

Yep, I think MIT for license

huh, i wasn't aware that we should add LICENSE to .Rbuildignore - I don't think check complains about that does it?

from pangaear.

gavinsimpson avatar gavinsimpson commented on August 28, 2024

@sckott I thought it did if it was in the top level of the sources as R expects arbitrary files to be in inst/.

from pangaear.

sckott avatar sckott commented on August 28, 2024

ah, sounds good

from pangaear.

sckott avatar sckott commented on August 28, 2024

@gavinsimpson hmm, check throws an error about path to license https://travis-ci.org/ropensci/pangaear/builds/34618941#L685 - how to avoid this when LICENSE file is in inst/ - this error doesn't happen I don't think when the file is in root dir.

from pangaear.

gavinsimpson avatar gavinsimpson commented on August 28, 2024

Ahh, my bad @sckott; seems i either misremembered this or things have changed somewhat since I last had to do this. Writing R Extensions states that LICENCE should be in the top level directory of the sorces, not inst/LICENCE as we discussed. However, it also talks about having LICENCE in both the top level "source" and "installation" directories. The only way to achieve the latter is via inst/LICENCE. So I wonder if we shouldn't put the full MIT licence in pangaear/LICENCE and the short two-line version in inst/LICENCE? That way people on Github see clearly what the licence is without needing to know the R ships with generic copies.

I'll have to look at the other commits to see if we need to undo or modify things to make this change.

from pangaear.

sckott avatar sckott commented on August 28, 2024

Okay, thanks @gavinsimpson

from pangaear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.