Giter VIP home page Giter VIP logo

Comments (9)

sckott avatar sckott commented on September 26, 2024

@andysouth I'll have a look

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

do you check locally with --as-cran ?

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

I think you need to submit rnaturalearthdata to CRAN first - then submit rnaturalearth - what do you mean by

submit rnaturalearth & rnaturalearthdata together

from rnaturalearth.

andysouth avatar andysouth commented on September 26, 2024

Thanks @sckott I hadn't thought to submit rnaturalearthdata to CRAN first, I'll do that.

Can you activate, or enable me to activate rnaturalearthdata on travis ?

It's telling me I don't have admin rights.

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

@andysouth Okay, travis is now on for that pkg, let me know if you need anything else

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

@andysouth you're now admin on both repos

from rnaturalearth.

andysouth avatar andysouth commented on September 26, 2024

Thanks @sckott rnaturalearthdata now succesfully on CRAN (hurrah!)

Ready to submit rnaturalearth, it passes locally and on travis but when I submit to winbuilder it fails due to installation of rnaturalearthhires.

Would you recommend submitting to cran anyway ?

winbuilder error below : and here

** running examples for arch 'i386' ... ERROR
Running examples in 'rnaturalearth-Ex.R' failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: ne_states
> ### Title: Get natural earth world state (admin level 1) polygons
> ### Aliases: ne_states ne_admin1
> 
> ### ** Examples
> 
> 
> # comparing using country and geounit to filter
> spdf_france_country <- ne_states(country = 'france')
The rnaturalearthhires package needs to be installed.
Installing the rnaturalearthhires package.
Installing package into 'D:/temp/RtmpGaDuTO/RLIBS_48c421ae5c10'
(as 'lib' is unspecified)
Error in value[[3L]](cond) : 
  Failed to install the rnaturalearthhires package.

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

Awesome it's on CRAN now.

Not sure, I'll have a look

from rnaturalearth.

sckott avatar sckott commented on September 26, 2024

rnaturalearth should pass check without packages in Suggests available - which sounds like that's not the case?

Examples in your pkg that need rnaturalearthdata or rnaturalearthhires need to be wrapped in

if (requireNamespace("ourpackage")) {
  # examples stuff
}

so examples then only run if that pkg is available

from rnaturalearth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.