Comments (4)
Simply adding set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
to CMakeLists.txt
solves this issue. I cannot find a branch for kinetic
and newer, where C++11 is a minimum requirement (http://www.ros.org/reps/rep-0003.html#kinetic-kame-may-2016-may-2021), so I can't / don't want to open a pull request for this.
from image_common.
@Tobias-Fischer, yeah, that should work around the issue, but it is still unclear to me what a "clean" solution is.
Firstly, adding this to the CMakeLists.txt has some issues:
- If you compile your workspace with catkin_cmake, that setting applies to all packages, if you use catkin_tools, it only applies to this one package.
- If you use a compiler that has C++14 or newer by default, this setting is a "downgrade".
- ...
Other unclear question: Do we need users of image_common to also compile with C++11, or is it fine for them to stick with an older standard?
Maybe the best approach would be to find a clean way to "compile the whole workspace with C++11" for OSX users and add that to the install instructions.
Some previous discussion:
- https://answers.ros.org/question/246369/the-good-c1114-the-bad-cmake_cxx_flags-and-the-ugly-cmake/?answer=246418#post-id-246418
- ros/robot_state_publisher#78
- ros-industrial/industrial_ci#89
- ros-planning/moveit#289
from image_common.
Yep, I'm getting the same thing.
from image_common.
For the record, I've had success with passing additionally setting -DCMAKE_CXX_STANDARD=14 in catkin config to compile lunar on macos Sierra (10.12).
from image_common.
Related Issues (20)
- Can't remap topic name and set hint at the same time; HOT 1
- image_transport::CameraPublisher::getNumSubscribers HOT 7
- How to deactivate those topics which are not needed? HOT 3
- [ROS2] error output when advertising publisher HOT 2
- Support Modern CMake practices HOT 2
- [Feature Request] Python bindings HOT 2
- fatal error: camera_info_manager/camera_info_manager.hpp: No such file or directory HOT 1
- New release for Rolling HOT 2
- Republishing multiple cameras has unexpected results HOT 6
- CameraInfoManager should register services inside node namespace
- image_transport::CameraPublisher does not support cv::Mat Type adapter
- Low message read rate on other device and excessive message size with tutorial publisher HOT 2
- disable_pub_plugins parameter commented out in ROS2 HOT 1
- Unable to leverage compressed image topics as expected, ROS2 Humble HOT 5
- Error will cmake
- image_transport publisher nodes should support subscriber specific compression config HOT 2
- Merge #276 broke downstream packages HOT 1
- Camera & info synchronization check timer wrong seconds value HOT 1
- No synchornization HOT 1
- undefined reference error after upgrading ros-rolling-image-transport
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image_common.