recent yaml-cpp releases require C++11 ==> compile error on macos about image_common HOT 4 OPEN

Simply adding set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11") to CMakeLists.txt solves this issue. I cannot find a branch for kinetic and newer, where C++11 is a minimum requirement (http://www.ros.org/reps/rep-0003.html#kinetic-kame-may-2016-may-2021), so I can't / don't want to open a pull request for this.

from image_common.

@Tobias-Fischer, yeah, that should work around the issue, but it is still unclear to me what a "clean" solution is.

Firstly, adding this to the CMakeLists.txt has some issues:

1. If you compile your workspace with catkin_cmake, that setting applies to all packages, if you use catkin_tools, it only applies to this one package.
2. If you use a compiler that has C++14 or newer by default, this setting is a "downgrade".
3. ...

Other unclear question: Do we need users of image_common to also compile with C++11, or is it fine for them to stick with an older standard?

Maybe the best approach would be to find a clean way to "compile the whole workspace with C++11" for OSX users and add that to the install instructions.

Some previous discussion:

• https://answers.ros.org/question/246369/the-good-c1114-the-bad-cmake_cxx_flags-and-the-ugly-cmake/?answer=246418#post-id-246418
• ros/robot_state_publisher#78
• ros-industrial/industrial_ci#89
• ros-planning/moveit#289

from image_common.

Yep, I'm getting the same thing.

from image_common.

For the record, I've had success with passing additionally setting -DCMAKE_CXX_STANDARD=14 in catkin config to compile lunar on macos Sierra (10.12).

from image_common.