Giter VIP home page Giter VIP logo

Comments (9)

christophebedard avatar christophebedard commented on August 19, 2024

Can you try the following?

  1. Go to https://github.com/$user/$repo/settings/actions (replace $user and $repo). Under "Workflow permissions," select "Read and write permissions." This might already be selected. Not sure why this option would fix this, but you never know.
  2. Create your own personal access token and add it as a secret: https://github.com/ros-tooling/action-ros-ci#Use-with-private-repos. If this private repo is under an organisation, you might need to create a special token, I don't remember how that works.

I can give it a try on my end with a private repo, but probably not today.

from action-ros-ci.

Nir-Az avatar Nir-Az commented on August 19, 2024

Thanks.

I tried "1" , didn't help.
2 is harder since it's an org, and according to action-ros-ci docs is not needed since we do not have private dependencies..
So I would prefer to wait and see your reproduction..

Or if you have other tips that might fix it..

Thanks,
Nir

from action-ros-ci.

christophebedard avatar christophebedard commented on August 19, 2024

2 is harder since it's an org, and according to action-ros-ci docs is not needed since we do not have private dependencies..

Yeah it used to work fine, but these token permissions seem to change all the time 😐

from action-ros-ci.

Nir-Az avatar Nir-Az commented on August 19, 2024

According to this line :

repoFullName = github.context.payload.pull_request.head.repo.full_name;

I think you try to clone the PR source repo and not the target PR repo, sounds right?
According to GitHub actions documentation

head means the source repo (which is not the workfile repo)
and base is the target repo.
The action is running againt the target repo and the token is valid for the target repo.

from action-ros-ci.

Nir-Az avatar Nir-Az commented on August 19, 2024

@timor-raiman FYI

from action-ros-ci.

christophebedard avatar christophebedard commented on August 19, 2024

Good observation.

Sounds like you have two private repos, and you use one as a fork (repo B) and open pull requests against the other one (repo A). Is that correct? My recommendation would be to not fork a private repo, but I guess that doesn't help you much.

Does it work if you use this change then? timor-raiman@c3757c1. I don't think it does (at least not for all cases), because cloning the target repo with a commit hash belonging to the source repo doesn't work.

from action-ros-ci.

Nir-Az avatar Nir-Az commented on August 19, 2024

Correct, forking the private repo and trying to PR from the fork to the main
@timor-raiman is trying to help with changes to your code..
Hopefully we can find a fix and you can review & merge it..

from action-ros-ci.

christophebedard avatar christophebedard commented on August 19, 2024

Of course, improvements and fixes are always welcome!

from action-ros-ci.

timor-raiman avatar timor-raiman commented on August 19, 2024

If dirk-thomas/vcstool#258 can be fixed, #816 would resolve this...

from action-ros-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.