`Writing a simple service and client (Python)`: regular spin in the tuto about ros2_documentation HOT 2 CLOSED

Since this is beginner's tutorial and minimal example, i think it intentionally uses spin_until_future_complete to wait for the specific future. i think this also makes sense as a minimal tutorial and https://github.com/ros2/rclpy/blob/88ce194b723594ccfcb42aacc3bfc4c405bbde95/rclpy/rclpy/executors.py#L315 explains well.

I am not necessarily against changing this, but i really like to hear more feedback.

from ros2_documentation.

We talked about this in the "waffle" issue triage meeting and the conclusion was that spin_until_future_complete is the right thing to use here, since that's the main purpose of this function is to help simplify situations like this example, but it would be a good idea to move the spin out of the send_request() method and into the main function, to better separate sending the request and waiting for it to complete. Also moving the spin activity to the main function will let them replace it in-place with spin if they decide to make it more complex.

from ros2_documentation.