Check for converter for every message might be performance issue about rosbag2 HOT 3 CLOSED

Best I can tell, this still exists and now refers to https://github.com/ros2/rosbag2/blob/master/rosbag2_cpp/src/rosbag2_cpp/readers/sequential_reader.cpp#L159

It seems to me that this simple check for nullptr is not of interest performance-wise, there are so many other things going on, that I am inclined to close this issue. @Karsten1987 if you think it's a problem, please reopen.

from rosbag2.

I am not yet convinced that this line really poses a performance issue. Also our rather crude performance tests give no such indication (but they might not be sensitive enough).
More importantly having a single converter will no longer suffice with when #52 is implemented. Then we most likely will have a converter for each topic and every message will have to be dispatched to the converter for the corresponding topic.

We could think about having a "identity converter" for topics that require no conversion. Doing so before #52 is not necessary IMHO.

from rosbag2.

We need to benchmark this to find out if it's necessary to change

from rosbag2.