Giter VIP home page Giter VIP logo

Comments (6)

fake-name avatar fake-name commented on June 18, 2024 1

The prefix directory is indeed should be present before run

The prefix directory is created during the run (at some point, at least. Perhaps it's not intentional?), but I think there's a race condition, or a mis-ordering so it's created after the attempt to write the module root. The issue is repeatable, at least for me.

from binder.

fake-name avatar fake-name commented on June 18, 2024

Ok, I moved into a plain folder on the local drive, and can confirm this problem exists without all the network/shared folder oddments.

Basically, if the path specified by --prefix doesn't exist, it is created, but {root-module}.cpp is never generated, and no error is thrown.

from binder.

lyskov avatar lyskov commented on June 18, 2024

@fake-name thank you for reporting this! The prefix directory is indeed should be present before run so such failure is expected, however we should indeed report an error in such cases. I will looks this up.

from binder.

HFTrader avatar HFTrader commented on June 18, 2024

I struggle with this as well until I realized the problem. It's interesting this issue has been hanging for a couple of years, seems easy enough to me to solve. So either:

  1. Check if the prefix folder exists and bail out if not; or
  2. At start, create the prefix folder if it does not exist, recursively
    Of course, now that I spent hours on this, I know and I've put a mkdir -p <prefix> on my script, for sanity.
    But it should indeed be solved within binder, for the mental sake of new users.

from binder.

HFTrader avatar HFTrader commented on June 18, 2024

Submitted this PR to solve this issue - not sure how to link the PR to the issue though
#124

from binder.

lyskov avatar lyskov commented on June 18, 2024

I updated master so prefix is now treated only as directory: a1870cb. I also added some error checks. So this should be fixed now.

from binder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.