Giter VIP home page Giter VIP logo

Comments (13)

lsolesen avatar lsolesen commented on August 26, 2024

If you want me to do it, I need your git name and git email you use for github, so I can give you commit credit for the commits.

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

I, just give me 1-2 hour(s)... To much things at the same time going on

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

@lsolesen all in i guess.. what do you think should we de with sourceforge repo?

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

@ole1986 The 0.13-exp branch does not seem to be based on master - it is behind with 97 commits. That means we will not be able to merge them, will we? Because I think 0.13-exp should be merged in as soon as the code is working, so there is only one master branch? There is no need having people supplying pull requests against master, when you think 0.13 is the new main branch? People can always access the old versions and if they think the old stuff is better, they can just fork the repos and work on previous versions.

As to the sourceforge repo, I think we should move over the issues, if you think they are still valid. Then update the website to redirect directly to the github-repo - and remove all code. If there is a mailing list, tell people the repo has moved - and then close it down. After maybe three months remove it entirely from sf? How does that sound?

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

@ole1986 Also it seems you took over all commits when you put it in your repos. E.g. I've added the composer.json, but you are now the committer?

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

@ole1986 If you see the commits in https://github.com/lsolesen/pdf-php-svn/commits/master I've retained committers, which I think is important for open source projects.

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

@ole1986 I can see in the commit log what your author information for git are. Should I do it?

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

I have now clue what you are talking about :-) but feel free to do what you want to ;-)

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

but in future when you change files you will be shown as committer I guess

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

btw what does the composer.json do?

from pdf-php.

ole1986 avatar ole1986 commented on August 26, 2024

If you have added the composer.json than also describe it in the README.md on how to use it!
regarding the committers I am pretty sure we can keep it know as it is.. and in future others will see who has committed the lines...

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

@ole1986 I've fixed it all up now. I've added experimental branch instead of your 0.13-exp-branch. Now all commits are correct and you got credit for your commits.

composer.json is information for packagist.org which basically can be used as a package manager in PHP. It is in all modern PHP repositories right now. We should add a section in the README.md on how to install the package, and there we could add information about composer. Opened an issue here: #3

from pdf-php.

lsolesen avatar lsolesen commented on August 26, 2024

Btw, This issue could be closed. Right now the code is up-to-date in the repository, I think.

from pdf-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.