[jsonschema] Table driven tests about rest-layer HOT 8 CLOSED

Go for 1.7 only, just add a build flags so it won't break 1.6 CI.

from rest-layer.

Started of with some simple cleanups first in #45. @yanfali, are you also happy with these?

from rest-layer.

Kind of unrelated, but shouldn’t we move all the jsonschema tests inside the package?

from rest-layer.

Go for 1.7 only, just add a build flags so it won't break 1.6 CI.

Actually, when I started coding, I found it was easy enough to support both (via build tags) -- I will use parallel sub-tests for Go 1.7 and a sequential approach without sub-tests for Go < 1.7.

My initial work lives on this branch.

It's based on top of #45. I will push it to a PR soonish.

from rest-layer.

Initial review for table-tests added in #46. @rs, when you have time, let me know if this is moving in the right direction, and what you would like to change.

from rest-layer.

I thought this was merged. I used the pattern recently in one of my projects.

from rest-layer.

I didn't convert all the jsonschema test, but yeah, I think we can close it.

from rest-layer.

shouldn’t we move all the jsonschema tests inside the package?

@rs, I am now doing this in #64. This commit also moves the remaining tests into table tests when appropriate.

from rest-layer.