no-inner-declarations wrongfully fails on exports after the first statement about rslint HOT 10 CLOSED

If rslint_parse parses the file as a module, the linting passes. Because in your code (if its parsed as a script), the parent.kind() is ERROR and thus will not be counted as a valid kind. This could be easily fixed by just checking for ERROR in the lint.

from rslint.

Oh that is true, and this brings up another point, the linter should not tread into ERROR nodes, it should skip them and their children because the data inside is non-sensical

from rslint.

This is going to be complicated, because many lints use .parent() or .children(), which are not guaranteed to not return ERROR.

from rslint.

that does not matter if the linter does not step into the children of error nodes

from rslint.

Ah yes, that makes sense. Misunderstood your message

from rslint.

Although the file is .mjs so it should be parsing as module 🤔

from rslint.

If I rename it to .mjs and run it, the linting passes

Edit: Nvm it doesn't. 😅 Because EXPORT_DECL is not in the valid kind array.

from rslint.

haha so the issue is still there, although we caught another issue for ERROR nodes

from rslint.

Oh haha, that makes sense, its an easy fix

from rslint.

Fixed in 970df03

from rslint.