Giter VIP home page Giter VIP logo

Comments (4)

pythiantech avatar pythiantech commented on August 11, 2024 1

@schloerke @jcheng5 Thanks, working fine now!

from crosstalk.

jcheng5 avatar jcheng5 commented on August 11, 2024

@schloerke, do you mind investigating? Seems likely to be in leaflet?

from crosstalk.

schloerke avatar schloerke commented on August 11, 2024

The leaflet map when it is made without shiny works as expected.

With shiny, the map is being redrawn multiple times. When you "click" and it selects data for the first time, it glitches as if it was reset is when the map is being redrawn. This glitch only happens when something within the data is being set. (The second click would not select new data, so it would work as expected.)

I believe the shared data is not being set properly (and causing a trigger to draw the map), as shinyreactlog is trying to depend on some shared data node that doesn't exist.

Somewhere in these set of commits: https://github.com/schloerke/shiny/compare/barret/reactlog...schloerke:barret-reactlog-merge?expand=1 is a change that is causing the issue. (barret/reactlog works as expected, barret-reactlog-merge contains the latest master from shiny)

The reactlog graph looks like:
screen shot 2018-09-05 at 10 54 27 am
The bottom observe ...

crosstalk/R/crosstalk.R

Lines 249 to 256 in 1c67fbf

observe({
selection <- private$.selectionCV$get()
if (!is.null(selection) && length(selection) > 0) {
self$.updateSelection(self$key() %in% selection)
} else {
self$.updateSelection(NULL)
}
})
... is changing the upper left input value with no dependency or isolation relationship. (WEIRD!)

The reactlog graph on a working as expected branch (schloerke/shiny - barret/reactlog) looks like:
screen shot 2018-09-05 at 10 54 45 am

from crosstalk.

schloerke avatar schloerke commented on August 11, 2024

Issue merged into rstudio/leaflet master branch.

@pythiantech Please let me know if you can still see the map resetting

devtools::install_github("rstudio/leaflet")

### example code

- Barret

from crosstalk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.