Giter VIP home page Giter VIP logo

Comments (4)

tolgap avatar tolgap commented on September 2, 2024 1

@rtfeldman While working on #105 I noticed that propN methods are sometimes used with multiple type aliases that do not have a notion of warnings attached to them, like textDecoration3:

textDecoration3 : TextDecorationLine compatibleA -> TextDecorationStyle compatibleB -> ColorValue compatibleC -> Mixin
textDecoration3 =
  prop3 "text-decoration"

So I left them untouched for the time being. Once we are sure that these types have error handling as well, we could incorporate propN functions to pass through warnings as well and that would clean up the code again.

from elm-css.

rtfeldman avatar rtfeldman commented on September 2, 2024

Now that ~ just resolves mixins, I think the properties themselves can handle these - and with context. Just need to have InvalidStyle build up an error message context instead of being a no-op so often, and have stuff like prop1 incorporate the notion of adding to the error context.

Then we can get fail fast, nice error messages, etc.

from elm-css.

rtfeldman avatar rtfeldman commented on September 2, 2024

Yep, makes sense to me!

from elm-css.

rtfeldman avatar rtfeldman commented on September 2, 2024

Closing in favor of #327

from elm-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.