Comments (4)
please advise on how to proceed
The standard practice would be to open a PR on this project with your proposed fix. (And also to clean it up a little - there's no need fo that TODO
comment 😸 )
You click the green "New Pull Request" button, then "compare across forks", and select your repository.
However, there's actually already an open PR for the same fix: #74
testing on older versions of Ruby
This change should work fine on ruby version 2.x
, too..
from shotgun.
The standard practice would be to open a PR on this project with your proposed fix. (And also to clean it up a little - there's no need fo that TODO comment 😸 )
Thank you. The comment was for myself, which is why I hadn't submitted a PR.
However, there's actually already an open PR for the same fix: #74
So this is all set then?
from shotgun.
So this is all set then?
All set as in what, exactly? There's nothing more to be done on this project, if that's what you mean. If/when the author sees the PR, they'll likely approve it and release a new gem version.
However, the author of this library has been active on github for quite some time. Perhaps someone else (you??) would rather take ownership with an "official" fork with the ruby 3.0-syntax fixed. Or perhaps you're happy to run your application using the branch for now.
from shotgun.
There's nothing more to be done on this project, if that's what you mean.
I was speaking with regard to this fix. Thank you for for pointing out that there was already a PR.
However, the author of this library has been active on github for quite some time. Perhaps someone else (you??) would rather take ownership with an "official" fork with the ruby 3.0-syntax fixed.
Thank you for the help, I was assuming that you were involved in the project.
from shotgun.
Related Issues (20)
- No output from Rack::CommonLogger HOT 8
- Can not run shotgun in cmd.exe on Windows 7 (64bit) HOT 8
- Can't use `require_relative` from within `./shotgun.rb`
- EM.next_tick never called HOT 2
- NameError: uninitialized constant Shotgun::Loader::YAML HOT 2
- direct users to sinatra-contrib reloader HOT 4
- Provide license information for the software
- shotgun don't work on windows
- Sinatra `enable :lock` doesn't work with Shotgun HOT 1
- LoadError when requiring 'net/ldap' gem HOT 5
- On stop server I get error in loop reactor HOT 1
- Incompatible with SuckerPunch Async HOT 1
- Shotgun visits every mapping in config.ru regardless the request HOT 10
- The way shotgun run HOT 4
- Rack 2.0.1 breaks requiring rack in bin/shotgun HOT 1
- Running a basic sinatra file shotgun breaks and cannot find 'rack/commonlogger' HOT 4
- Doesn't work on macOS High Sierra HOT 8
- e HOT 1
- Ruby 3.0.0 -- every webserver seems to error with "wrong number of arguments (given 2, expected 1) (ArgumentError)" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shotgun.