Giter VIP home page Giter VIP logo

Comments (12)

rkh avatar rkh commented on May 18, 2024

I'm against including another engine that is not 1.9 compatible. Also, it seems to be no longer maintained.

from tilt.

josh avatar josh commented on May 18, 2024

Seems bad. We should make it clear that any tilt engine needs to be 1.8.7 and 1.9.x compat.

from tilt.

rkh avatar rkh commented on May 18, 2024

Judging from the tests that fail, actually making it 1.9 compatible wouldn't be that hard, but since it's not on github (in fact, I can't even find the repository anywhere), and there has not been a release in three years...

from tilt.

hannesg avatar hannesg commented on May 18, 2024

Hi there.
I'm using tenjin under 1.9 a lot and i didn't have any problem with it.
It's right, the ruby version is not under developement anymore, but it is pretty mature and fast ( i like it a lot ).
I've already hacked it a bit. Is anyone still interested in this feature?
If so, i would write the code for that.

from tilt.

rkh avatar rkh commented on May 18, 2024

Last time I checked (see comment above) the tests didn't pass on 1.9. One option would be for you to become the maintainer of it or a fork, that would be fully 1.9 compatible.

from tilt.

hannesg avatar hannesg commented on May 18, 2024

Yep, if already contacted the original author yesterday. If he agrees i'll maintain that.

from tilt.

hannesg avatar hannesg commented on May 18, 2024

Hi
the author hasn't replied yet, but i've made a first working implementation of the tenjin support.
I would be very pleased if somebody could review the changes:
hannesg@1b19c79

Thank you!
Hannes

from tilt.

rtomayko avatar rtomayko commented on May 18, 2024

@hannesg: Could you move that to a branch and submit a pull request please? Thanks!

from tilt.

hannesg avatar hannesg commented on May 18, 2024

k, done

from tilt.

hannesg avatar hannesg commented on May 18, 2024

Hi,
there was a new release ( tenjin 0.7.0 ).
It changed several things but should be compatible. Ruby 1.9. support is explicitly stated in the release message.

I'll check compatiblity over the weekend and send patches if required.

from tilt.

josephholsten avatar josephholsten commented on May 18, 2024

anyone want to review the patch in #116

from tilt.

judofyr avatar judofyr commented on May 18, 2024

Tenjin hasn't had any updates for about four years. However, if someone really wants it into Tilt I'll accept it if someone opens a new pull request.

from tilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.