Giter VIP home page Giter VIP logo

Comments (2)

rtomayko avatar rtomayko commented on May 17, 2024

I see that require_template_library(name) in called in #compile!, and you have a warning about it not being thread safe. I suggest requiring the library when it's Template subclass is initialized. That would be a bit more robust, even if not completely thread safe (is it?).

That's not a bad idea. It's still not thread safe unless the class is first created at load time. Still, I like moving it to #initialize just because it feels better there.

Also you don't need to use if defined?() on the require, because require won't require the same library twice.

Kernel#require is a lot more expensive than the defined? check. Benchmark it: you'll be surprised.

from tilt.

rtomayko avatar rtomayko commented on May 17, 2024

I added Tilt::Template#initialize_engine, which is called only once per template subclass the very first time the class is initialized. All library requiring was moved to these methods.

from tilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.