Bug: DpadSpanSizeLookup's getSpanSize function is being called infinitely after removing an item about dpadrecyclerview HOT 8 CLOSED

I manage to reproduce it with this test:

 @Test
    fun testGridRemovalWithSpanLookupDoesNotCrash() {
        onRecyclerView("Change span size") { recyclerView ->
            recyclerView.setSpanSizeLookup(object : DpadSpanSizeLookup() {
                override fun getSpanSize(position: Int): Int {
                    val adapter = recyclerView.adapter as AbstractTestAdapter<*>
                    val item = adapter.getItem(position)
                    return if (item % 9 == 0) {
                        recyclerView.getSpanCount()
                    } else {
                        1
                    }
                }
            })
        }
        KeyEvents.pressDown()
        val oldViewBounds = getRelativeItemViewBounds(position = 1)
        mutateAdapter { adapter ->
            adapter.removeAt(3)
            adapter.removeAt(13)
        }
        assertFocusAndSelection(1)
        assertItemAtPosition(position = 1, item = 1)

        val newViewBounds = getRelativeItemViewBounds(position = 1)
        assertThat(newViewBounds).isEqualTo(oldViewBounds)
    }

Will take care of it for the next release

from dpadrecyclerview.

Released in 1.3.0-alpha03 now

from dpadrecyclerview.

@tyrel-carlson is this similar to your setup?

I'm not able to reproduce this. Can you give me more details about the contents of your adapter and which position you're removing?

from dpadrecyclerview.

Here's my current test that is passing:

 @Test
    fun testGridRemovalWithSpanLookupDoesNotCrash() {
        onRecyclerView("Change span size") { recyclerView ->
            recyclerView.setSpanSizeLookup(object : DpadSpanSizeLookup() {
                override fun getSpanSize(position: Int): Int {
                    return if (position % 5 == 0) {
                        recyclerView.getSpanCount()
                    } else {
                        1
                    }
                }
            })
        }
        val oldViewBounds = getRelativeItemViewBounds(position = 0)
        mutateAdapter { adapter ->
            adapter.removeAt(adapter.itemCount - 1)
            adapter.removeAt(adapter.itemCount - 1)
            adapter.removeAt(0)
            adapter.removeAt(0)
        }
        assertFocusAndSelection(0)
        assertItemAtPosition(position = 0, item = 2)

        val newViewBounds = getRelativeItemViewBounds(position = 0)
        assertThat(newViewBounds).isEqualTo(oldViewBounds)
    }

I'm trying to replicate your setup, but I need more details

from dpadrecyclerview.

@tyrel-carlson is this similar to your setup?

I'm not able to reproduce this. Can you give me more details about the contents of your adapter and which position you're removing?

Yeah that looks like my own. My date headers fill the grid but are not focusable themselves.

from dpadrecyclerview.

I manage to reproduce it with this test:

 @Test
    fun testGridRemovalWithSpanLookupDoesNotCrash() {
        onRecyclerView("Change span size") { recyclerView ->
            recyclerView.setSpanSizeLookup(object : DpadSpanSizeLookup() {
                override fun getSpanSize(position: Int): Int {
                    val adapter = recyclerView.adapter as AbstractTestAdapter<*>
                    val item = adapter.getItem(position)
                    return if (item % 9 == 0) {
                        recyclerView.getSpanCount()
                    } else {
                        1
                    }
                }
            })
        }
        KeyEvents.pressDown()
        val oldViewBounds = getRelativeItemViewBounds(position = 1)
        mutateAdapter { adapter ->
            adapter.removeAt(3)
            adapter.removeAt(13)
        }
        assertFocusAndSelection(1)
        assertItemAtPosition(position = 1, item = 1)

        val newViewBounds = getRelativeItemViewBounds(position = 1)
        assertThat(newViewBounds).isEqualTo(oldViewBounds)
    }

Will take care of it for the next release

Thanks for your consideration. By the way, can you tell me how can I manage to fix this until next version is released?

from dpadrecyclerview.

As a workaround, notifyDataSetChanged instead of individual notifyItemRemoved calls should fix it for now. But I plan to release this fix today anyway

from dpadrecyclerview.

Yeah I noticed too that calling notifyDataSetChanged is a fix but it prevents loading of item data in my case, so I prefer to wait for your release, thanks for your great work!

from dpadrecyclerview.