TypeError in string interpolation (when #to_s does not return a String) about rubinius HOT 4 CLOSED

http://github.com/evanphx/rubinius/blob/65944505d2f2a34d29944d27457a0479cbf0ffb0/lib/compiler/ast/literals.rb#L289

  # We also do not handle any case where #to_s does not actually return a
  # String instance.

So yes, it seems that it's intentional.

from rubinius.

Umm, just realized you wrote the comment I quoted. So uhh.. yeah.

from rubinius.

This is particularly hairy because we call #to_s in the bytecode, so by the time the string construction starts, we've lost the object we called #to_s on to use the fallback.

We'd have to call out to a helper that calls #to_s and checks the return value. Thats expensive since this almost never happens anyway.

I wonder if I shouldn't just take the value, and if it's not a string, return it as one. So in your example case, the value would be "1", since we'd render the 1.

Perhaps I'll just do that.

from rubinius.

Use a fallback conversion in string_build. Closed by 33daa62.

from rubinius.