Pass options through to command. about ruby-git HOT 4 CLOSED

👍

I agree with you in that we should have a way to support options in a more flexible way.

It won't be an easy change since its a modification over the design of the current version.

Let's see what we can do.

from ruby-git.

👍 Ditto. Not currently any easy way to clone with --reference=file://blah

What about just deleting the opts keys as they're used, and use the remaining ones to directly create the remaining?
https://github.com/schacon/ruby-git/blob/master/lib/git/lib.rb#L58-L67

Perhaps we could use an approach something like this (see link above for original)?

      arr_opts = []
      arr_opts << "--bare" if opts.delete(:bare)
      arr_opts << "--recursive" if opts.delete(:recursive)
      arr_opts << "-o" << opts.delete(:remote) if opts[:remote]
      arr_opts << "--depth" << opts.delete(:depth).to_i if opts[:depth] && opts[:depth].to_i > 0
      arr_opts << "--config" << opts.delete(:config) if opts[:config]

      # Do something with remaining `opts` hash...
      opts.each do |opt, val|
        arr_opts << "--#{opt} #{val}".strip
      end

      arr_opts << '--'
      arr_opts << repository
      arr_opts << clone_dir

#delete passed the value we might need as it throws it away. The downside is that it's not clear to read, but maybe we could extend the hash and alias some clearer method for #delete... maybe #pop_opt or something.

So here, if I passed in (above and beyond the currently accepted stuff) this:

{:reference => "/path/to/ref/repo", :something => nil}

It would further append this to the command --reference /path/to/ref/repo --something

from ruby-git.

👍 would also need it for --mirror :)

from ruby-git.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from ruby-git.