Comments (5)
Take a look at line 38 in http://github.com/gunark/rubycas-server/blob/master/lib/casserver/conf.rb
We check whether the authenticator config is an array and convert if required.
Requiring users to add a tiny dash in front of their authenticator settings in their config.yml might be a bit too esoteric. Unless your intimately familiar with YAML, it's not at all obvious that - means "array". The goal is to make the initial set up process for new users as easy as possible, so in the interest of simplicity I'd rather allow users to enter a non-array value for their authenticator.
from rubycas-server.
I thought it was an intentional change, so I was changing the config.
I know your concern and I totally agree with it.
But this line:
http://github.com/gunark/rubycas-server/blob/master/lib/casserver/conf.rb#L38
didn't really fix the problem, it didn't touch $CONF[:authenticator].
And this line:
http://github.com/gunark/rubycas-server/blob/01238483a9691dcf0deb0468ca8b41a7603e7071/lib/casserver/controllers.rb#L136
i.e. $CONF.authenticator[auth_index]
Thinks $CONF.authenticator is an array, not $AUTH
.
I've reverted the config change, and applied another patch
to ensure $CONF.authenticator is always an array.
http://github.com/godfat/rubycas-server/commit/ab71dff90792aeeb9025e706c7e58dba1140e3d8
i.e. $CONF[:authenticator] = [$CONF[:authenticator]]
I don't think this is a good idea, but just a quick and dirty fix.
Thanks for your reply.
from rubycas-server.
Github is refusing to let me apply patches right now... something about the repository being migrated to a new server.
I'll get this stuff applied ASAP.
Thanks for all the hard work.
from rubycas-server.
has this been updated as I wasted plenty of time finding out the config requires an extra - in order for my server not to crash with 'premature end of script' errors.
thanks.
from rubycas-server.
Ah crap I must have closed this without actually pulling in the fix. Should be there now. Thanks for the reminder.
from rubycas-server.
Related Issues (20)
- Issues authenticating with remote devise HOT 2
- Deal with inactive or frozen account
- Deal with inactive or frozen account HOT 2
- Cross domain ajax between rubycas client apps HOT 1
- How users can change their password with rubycas-server?? HOT 3
- user active flag HOT 1
- Security bug report HOT 14
- ProxyTicket not validated
- SQLAuthLogic and SQLRestAuth call user_model class method HOT 1
- Logout endpoint tries to render non-existent view in some cases
- New install, getting error creating DB:
- Using Multiple authenticators fails when one or more of them are not loaded
- Logout error HOT 1
- unable to login HOT 1
- Attributes always treated as arrays? HOT 1
- bundle exec errors HOT 12
- can't render login view with service url if login failed
- uninitialized constant Psych::ENGINE (NameError) HOT 11
- Is this repo still alive? HOT 1
- ActiveRecord::DangerousAttributeError - changed is defined by ActiveRecord
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubycas-server.