Query.generate_get_params should support arrays about bubblewrap HOT 6 CLOSED

Hm, the question is - how do we expect the URL to look like?

Let's say we are passing { types: [food, restaurant, shop] }
with your solution it generates:

localhost?types[]=food&types[]=restaurant&types[]=shop

The solution we have right now generates

localhost?types=[food, restaurant, shop]

However, the Google Places API separates by Pipe symbol (value1|value2|value3)

localhost?types=food|restaurant|shop

The fourth option is to use CSV

localhost?types=food,restaurant,shop

from bubblewrap.

The way Rails (and other frameworks) encode and expect the params is compatible with @tzusman patch:

>> { :types => ['food', 'restaurant', 'shop'] }.to_params
=> "types[]=food&types[]=restaurant&types[]=shop"

And that should also be true for POST params.
Maybe we can provide a wrapper method that takes an argument to pick the encoding style (rails, pipe, csv) with rails being the default?

from bubblewrap.

@mneorr as per our discussion, let's use the Rails default for 1.0 and add support for more encodings later on.
This is the last ticket before we push 1.0! \0/

from bubblewrap.

Sure, I'll amend the spec now and add the new behavior.

from bubblewrap.

The proposed solution would work great. Thanks for looking into this, and for building BubbleWrap!

from bubblewrap.

Added, tested ;)

Thanks @tzusman

from bubblewrap.