Giter VIP home page Giter VIP logo

Comments (6)

Justin-CB avatar Justin-CB commented on May 10, 2024

If this is still a problem, I think it would be better to use a workaround, rather than have it not wprk at all.

from ruffle.

Herschel avatar Herschel commented on May 10, 2024

It's less of a problem since the alternate canvas drawing path was added; simple shapes draw directly via canvas paths, and the color transform can be directly applied to the colors. So anything that is made up of solid fills will work with color transforms.

It still occurs for things that fallback to the old SVG rendering path. Unfortunately I don't think there's a good way to do this otherwise; it'd probably require rendering the art to an intermediate buffer (and several times if it has both an additive and a multiplicative color). I might implement this workaround when we add the blend modes/filter, which will require bitmap caching support anyway.

I would be more concerned about it if I didn't plan to have a WebGL renderer, where the issue doesn't apply.

from ruffle.

Herschel avatar Herschel commented on May 10, 2024

WebGL support was merged in and made default in #520, so this is no longer an issue in general use. However, the issue still occurs if the canvas backend is used.

from ruffle.

bbb651 avatar bbb651 commented on May 10, 2024

I found this polyfill that uses a second hidden canvas to apply the filter and copy draw it onto the main canvas, I haven't tested it but it'll probably be a noticeable hit in performance, I still think it's better than nothing.

from ruffle.

Lord-McSweeney avatar Lord-McSweeney commented on May 10, 2024

Safari still doesn't support this.

from ruffle.

karlcow avatar karlcow commented on May 10, 2024

Some discussions happening on https://bugs.webkit.org/show_bug.cgi?id=198416

from ruffle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.