Insert the button into location bar about offline-qr-code HOT 6 CLOSED

Indeed, initially I just added in as a browser action (that's how that is technically called) instead of a an address bar button or so, because that's Mozilla's recommendation for stuff you can do on every site.

However, I'd certainly like to offer the option to (also) put it into the address bar. The implementation work is likely not too hard, but it could be problematic that the add-on itself cannot hide the buttons (AFAIK), so the user would have to configure the display to move one button away or so.
And having two buttons for the same purpose when the add-on is initially installed is not a good (first) user experience.

from offline-qr-code.

Okay, maybe I am wrong, as it seems the add-on can disable the action. 😃

from offline-qr-code.

This button also works on Android.

from offline-qr-code.

Both buttons work on Android. Currently it is just shown in the "…" menu as a text entry.

from offline-qr-code.

So I tried to implement this, but it does not look nice:

This is the state where the address bar (page action) is enabled, and the toolbar icon (browser action) is disabled.
As you can see, this looks weird. There are two/three problems:

• Neither the browser action, nor the page action can be completely hidden via JS/from the add-on. Only the user could do this. And as for the page action, not even the user can completly hide it, it will always be visible in the overflow menu:
  
• The icon of the page action cannot be adjusted to the theme. That's why it looks so dark in the screenshot.
• The browser action icon looks awkward when disabled.

If you want to try it yourself, here is a patch file (I needed to rename it to txt, because of GitHub's upload restrictions):

patch-pageAction.txt

Thus I am closing this issue. Unfortunately it is not possible in a sane way, currently.

from offline-qr-code.

As for the color issue, I've at least added a comment.

from offline-qr-code.