Comments (9)
Why not just canvas {width: 100%}?
Because the size can be dynamically adjusted by the user/by settings in the options. "Automatically adjust" should roughly correspond to this.
adding note in the options menu size area stating size will be limited if it is in the overflow menu
I want to avoid showing such a thing when the user does not actually use the overflow menu.
So some ideas I have:
- totally ignore the user's size setting, when the overflow menu is detected and just choose 100% width as noted?
- show some error, if overflow is detected (as this issue originally proposed)
This whole size thing is also related to Android. Also there, depending on the setting, the size of the QR code can be a little suboptimal… (#151)
Generally, I have to admit, that this whole size handling got quite complex and we have edge cases like this one.
What I, however, want to keep, is the custom resizer (#57). And even on Android tablets, this may be a useful.
from offline-qr-code.
I'm not actually a user of your extension but I like its simple popup UI...
Well… then you should definitively try it out. 😃
(Please do so, without having done so, you can hardly judge what features may be missed or how it currently works.)
mobile screen: fill screen
Problem I would have here is the case of tablets… There you are unlikely to want this…
overflow menu: fill available area
That is a good idea and I am thinking about it, as I've said:
So some ideas I have:
[…]
- totally ignore the user's size setting, when the overflow menu is detected and just choose 100% width as noted?
This extension even accounts for managed options... who needs managed options for a QR code generator?
I don't know/care, it's easy to implement though if you've abstracted it once… 😊 (actually, it's not even properly tested: #177) So I cannot answer you this option.
If you skip all of these options, your extension is already done and you can move onto a new project.
Well… implementing this properly certainly takes work, but yes, it could eliminate several problems.
Anyway, let's better discuss this in a new issue, as I like the general idea. I've summarized problems and your ideas in #187, so please let's discuss this there.
This issue could be obsoleted by it, but for now, let's keep this issue a "good first issue" for a small warning. 😄
from offline-qr-code.
https://discourse.mozilla.org/t/width-of-popup-overflow-menu/27939
from offline-qr-code.
One can just estimate it based on the width…
STR:
- manual set high QR code size
- open in overflow menu
So what may be done here:
- check that the popup is shown like that (width)
- compare with QR code size
- if it is likely to be shown distorted as in the image above, maybe show a warning message (depends on #83) that it may be shown in a not-so good way
Add an action button that takes the user to the settings. (Try to let it highlight using the target selector, which has been made for this/can be used for exactly that.Oh, wait, you cannot manually open the about:addons like that, too bad.)
from offline-qr-code.
seems like Firefox overflow system breaks several add-ons, so easiest start may be just adding note in the options menu size area stating size will be limited if it is in the overflow menu.
from offline-qr-code.
The default size is specified in the options:
from offline-qr-code.
Because they likely do not want to resize it each time the popup is opened. That's also why there is the "remember size" option: You can open the popup, adjust it for your screen/environment etc. and it is just restored again.
I'll certainly won't remove that feature. Or what are you actually suggesting?
from offline-qr-code.
Right, that's the whole point, you added more work for yourself because now you also have to maintain and test it sweat_smile
Well yeah, but remember I use the same for other add-on's too. So there it is potentially more useful than for a QR code generator. Anyway, that's hardly a thing we need to discuss here…
I don't use QRs
At least for trying/testing it out, you should have a look. 😃
from offline-qr-code.
https://github.com/TinyWebEx/EnvironmentDetector could help here.
from offline-qr-code.
Related Issues (20)
- Extract information from a QR Code picture (.svg / .png / etc. ) HOT 2
- Save Page with Overlaid QR Code HOT 3
- Support define text template for generate similar QRs HOT 4
- Use system clipboard content than tab url to gen code. HOT 6
- Save QR SVG to copy-paste clipboard HOT 5
- Can we have a function to READ QR Codes as well HOT 2
- Updated translations for 'zh_TW': zh_TW HOT 1
- QR-code window does not open HOT 1
- Add shortcut icon to the address bar HOT 1
- Updated translations for 'uk': Ukrainian (Українська) HOT 1
- Configuration for hiding random tips HOT 1
- The undo button is too far from reset button HOT 10
- Automatically retrieve text from clipboard and generate QR - (pl) Automatycznie pobieraj tekst ze schowka i generuj QR HOT 3
- Encrypted exchange by QR-code channel HOT 5
- Spanish translation contribution HOT 8
- Updated translations for 'es': Spanish (Español) HOT 2
- Updated translations for 'zh_CN': zh_CN HOT 3
- Improve Contribution documentation HOT 1
- Add context-menu item for generating a QR code for _the current page_ HOT 7
- Updated translations for Spanish (Español) with a few orthographic corrections HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from offline-qr-code.