Hot key for QR code generation/popup about offline-qr-code HOT 7 CLOSED

Maybe https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands is what you were looking for...

from offline-qr-code.

Ah, yes, found it: https://developer.mozilla.org/de/Add-ons/WebExtensions/API/commands/update

from offline-qr-code.

Yeah, indeed.

So maybe we can collect hot key combinations for different OSes that.

So as a default I would already propose. I just noticed "Ctrl+R" reloads the page, so we cannot use that. Ctrl+G also not available. The same with shift there, too…
Ctrl+Q quits the browser on many OSes (Linux and MacOS, I think), so we cannot use that too…

Mhh, which one is even still possible to use? 🤔

However, one thing will be clear: It is not customizable by the user. That makes things easier though, so I don't think this is particularly bad. 😄
The only thing we could do is offer some alternatives, but I think that is not really worth it. 😃

from offline-qr-code.

It seems changing the shortcut is actually possible to implement with Firefox, because this add-on writes:

Starting with Firefox 60 you can also change the default shortcut in the configuration panel (Firefox Beta, Firefox Developer Edition, and Firefox Nightly are already supported). The API is available only after Firefox 60.

So one would need to look at how they did it/what API they used.

from offline-qr-code.

The source code is at https://github.com/ReDEnergy/SessionSync

from offline-qr-code.

As for v1.2 I think a default hotkey would, however, be enough…

So I've opened #67 for this as a follow-up issue.

from offline-qr-code.

I think the hardest thing about this issue here actually is not the hot key itself, but that:

In such a case, it should be determinated, whether some text is selected. If it is, it should use that text for the QR code, otherwise just the URL.

This may require some content script to be injected (remember, @ENT8R 😉; I said we might need this again… 😆). Of course, not doing so is always preferred, but I see no other way of accomplishing it without some injection.

from offline-qr-code.