Giter VIP home page Giter VIP logo

Comments (4)

ghislainfourny avatar ghislainfourny commented on June 15, 2024 1

Dear @fkellner

Many thanks for wrapping this up. This is very appreciated. In the next release the documentation will point to your script as an additional possibility of installation, you can see a preview here:

https://sparksoniq.readthedocs.io/en/latest/Getting%20started/

Also, in the next release the CLI will be more convenient (but in a backward compatible way so it should not break your script). Feel free to adjust your script if you wish to once the release is out:
https://sparksoniq.readthedocs.io/en/latest/CLI/

Kind regards,
Ghislain Fourny

from rumble.

ghislainfourny avatar ghislainfourny commented on June 15, 2024

Dear @fkellner

Thank you for your contribution. It is highly appreciated. I have forwarded it to the team in order to give you feedback.

I think that the best approach would be if you could create a git repository (owned by you) with your script, and we will gladly point to it in our documentation. That way, it will be straightforward for you to maintain it without having to go through reviews every time.

Thanks again for this nice contribution!

Kind regards,
Ghislain Fourny

from rumble.

thomastzhou avatar thomastzhou commented on June 15, 2024

Dear @fkellner

I tried it on CentOS 7 and with Oracle JDK 1.8.0_91. The script worked great for me and was very convenient overall. A small issue is that the JDK I'm using expects the flag -version instead of --version (which I believe is true for all Oracle JDKs <= 8) so it shows an error in some non-critical branches. I have not tested but I believe OpenJDK parses both flags so maybe a simple update to use the -version flag could be more robust.

Let us know if you make a repository with the script and we will happily point to it from the documentation!

from rumble.

fkellner avatar fkellner commented on June 15, 2024

Dear @ghislainfourny and @thomastzhou,

thank you for the quick feedback, and sorry for the long response time!
I incorporated the flag change and published the install script here:
https://github.com/fkellner/rumbledb-install-script

Best Regards
Florian Kellner

from rumble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.